From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] freescale-imx: separate variable assignment from Makefile
Date: Tue, 1 Oct 2013 21:44:20 +0200 [thread overview]
Message-ID: <20131001214420.34d3ef48@skate> (raw)
In-Reply-To: <1380650790-18097-2-git-send-email-eric.nelson@boundarydevices.com>
Dear Eric Nelson,
On Tue, 1 Oct 2013 11:06:29 -0700, Eric Nelson wrote:
> This patch pulls the variable assignments for the site and
> version from freescale-imx.mk and places them into freescale-imx.inc
> so they can be used by components in other trees
> (e.g. gstreamer plugins).
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> package/freescale-imx/freescale-imx.inc | 9 +++++++++
> package/freescale-imx/freescale-imx.mk | 6 +-----
I know there has been past discussion with Arnout on this, but I
clearly don't agree with the introduction of this new .inc extension in
our makefiles.
Due to how make expands variable, I am not sure it is needed for the
FREESCALE_IMX_VERSION and FREESCALE_IMX_SITE variables to be defined
before they are used.
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-01 19:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-01 18:06 [Buildroot] [PATCH 0/2] i.MX: update gst-fsl-plugin version Eric Nelson
2013-10-01 18:06 ` [Buildroot] [PATCH 1/2] freescale-imx: separate variable assignment from Makefile Eric Nelson
2013-10-01 18:08 ` Eric Nelson
2013-10-01 19:44 ` Thomas Petazzoni [this message]
2013-10-01 21:19 ` Eric Nelson
2013-10-01 21:27 ` Thomas Petazzoni
2013-10-01 21:50 ` Eric Nelson
2013-10-01 18:06 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: Bump version and change URL to match other i.MX components Eric Nelson
2013-10-01 20:48 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001214420.34d3ef48@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox