From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 10/16] libcgroup: new package
Date: Tue, 1 Oct 2013 21:48:53 +0200 [thread overview]
Message-ID: <20131001214853.62a871b3@skate> (raw)
In-Reply-To: <1380137571-688-11-git-send-email-clshotwe@rockwellcollins.com>
Dear Clayton Shotwell,
On this one, we're almost ready to go. A few comments below.
On Wed, 25 Sep 2013 14:32:45 -0500, Clayton Shotwell wrote:
> diff --git a/package/libcgroup/Config.in b/package/libcgroup/Config.in
> new file mode 100644
> index 0000000..17d2db2
> --- /dev/null
> +++ b/package/libcgroup/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_LIBCGROUP
> + bool "libcgroup"
> + help
> + libcgroup is a library that abstracts the control group file system in Linux.
I believe this line is slightly too long. Also, the upstream URL is
missing. It should probably be:
http://libcg.sourceforge.net/
> diff --git a/package/libcgroup/libcgroup.mk b/package/libcgroup/libcgroup.mk
> new file mode 100644
> index 0000000..06f1e60
> --- /dev/null
> +++ b/package/libcgroup/libcgroup.mk
> @@ -0,0 +1,38 @@
> +################################################################################
> +#
> +# libcgroup
> +#
> +################################################################################
> +
> +LIBCGROUP_VERSION = 0.38
> +LIBCGROUP_SOURCE = libcgroup-$(LIBCGROUP_VERSION).tar.bz2
> +LIBCGROUP_SITE = http://sourceforge.net/projects/libcg/files/latest/download
> +LIBCGROUP_LICENSE = LGPLv2.1
> +LIBCGROUP_LICENSE_FILES = COPYING
> +
> +LIBCGROUP_INSTALL_STAGING = YES
> +
> +# Undefining _FILE_OFFSET_BITS here because of a "bug" with glibc fts.h
> +# large file support. See https://bugzilla.redhat.com/show_bug.cgi?id=574992
> +# for more information.
> +LIBCGROUP_CONF_ENV = \
> + CXXFLAGS+="-U_FILE_OFFSET_BITS" \
> + CFLAGS+="-U_FILE_OFFSET_BITS"
> +
> +LIBCGROUP_CONF_OPT = \
> + --disable-tools \
> + --disable-daemon \
> + --disable-initscript-install
> +
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> + LIBCGROUP_CONF_OPT += --enable-static --disable-shared
> +endif
This part is not needed, as it is passed by the autotools
infrastructure already.
Maybe you want to resend just this patch with those fixes, so we can
get it merged quickly, independently of the other SELinux changes.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-01 19:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 19:32 [Buildroot] [PATCH v3 00/16] SELinux Buildroot Additions Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 01/16] pcre: Add host build support Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 02/16] libselinux: new package Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 03/16] ustr: " Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 04/16] bzip2: Add host build shared library installation Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 05/16] libsemanage: new package Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 06/16] checkpolicy: " Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 07/16] sepolgen: " Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 08/16] sqlite: Add host build support Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 09/16] setools: new package Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 10/16] libcgroup: " Clayton Shotwell
2013-10-01 19:48 ` Thomas Petazzoni [this message]
2013-10-01 20:04 ` clshotwe at rockwellcollins.com
2013-10-01 21:14 ` Thomas Petazzoni
2013-09-25 19:32 ` [Buildroot] [PATCH v3 11/16] python-pyparsing: Add host build option Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 12/16] audit: new package Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 13/16] policycoreutils: " Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 14/16] python-pyxml: " Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 15/16] refpolicy: " Clayton Shotwell
2013-09-25 19:32 ` [Buildroot] [PATCH v3 16/16] shadow: " Clayton Shotwell
2013-10-01 19:51 ` [Buildroot] [PATCH v3 00/16] SELinux Buildroot Additions Thomas Petazzoni
2013-10-01 20:32 ` clshotwe at rockwellcollins.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131001214853.62a871b3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox