Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/6] qt5: bump to 5.1.1
Date: Fri, 4 Oct 2013 09:09:58 -0300	[thread overview]
Message-ID: <20131004120957.GA5127@localhost> (raw)
In-Reply-To: <1379655795-22429-2-git-send-email-fatih.asici@gmail.com>

Hi Fatih,

Nice work!

On Fri, Sep 20, 2013 at 08:43:10AM +0300, Fatih A??c? wrote:
> Following patches are removed since they are upstreamed:
>   - qt5base/qt5base-0001-eglconvenience-add-egl-to-CONFIG-to-get-correct-incl.patch
>   - qt5jsbackend/qt5jsbackend-0002-fix-uclibc.patch
> 
> Remove "-nomake demos" from configure options since "demos" directory is
> merged into examples.
> 
> Signed-off-by: Fatih A??c? <fatih.asici@gmail.com>
> ---
>  package/qt5/qt5.mk                                 |    4 +--
>  package/qt5/qt5base/Config.in                      |    2 ++
>  ...nce-add-egl-to-CONFIG-to-get-correct-incl.patch |   32 -------------------
>  ...-Add-egl-cflags-when-opengles2-is-enabled.patch |   32 +++++++++++++++++++
>  .../qt5/qt5base/qt5base-0002-mkspecs-files.patch   |    5 +--
>  package/qt5/qt5base/qt5base.mk                     |   10 ++++--
>  package/qt5/qt5declarative/qt5declarative.mk       |    1 +
>  .../qt5jsbackend-0002-fix-uclibc.patch             |   33 --------------------
>  package/qt5/qt5quick1/qt5quick1.mk                 |    3 +-
>  9 files changed, 48 insertions(+), 74 deletions(-)
>  delete mode 100644 package/qt5/qt5base/qt5base-0001-eglconvenience-add-egl-to-CONFIG-to-get-correct-incl.patch
>  create mode 100644 package/qt5/qt5base/qt5base-0001-xcb-Add-egl-cflags-when-opengles2-is-enabled.patch
>  delete mode 100644 package/qt5/qt5jsbackend/qt5jsbackend-0002-fix-uclibc.patch
> 

I'm trying the series right now and noticed that qt5base build fails if
PNG is not enabled. Apparently, you noticed first as you already
reported this and provided a fix:

  https://bugreports.qt-project.org/browse/QTBUG-33496

Care to add this patch as well to Buildroot and push the fix upstream?

Apparently with this new version of Qt5, the examples get built: they
aren't built with the current v5.0.2.

So, it would be nice to add support to build the examples (which we
had in Qt 4.8).

I think embedded developers might find examples of great use: I use them to
quickly check the hardware support is OK (test touchscreen, the buttons,
and so on).

I would do it myself, but I tried to use something like this:

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index 0106c2c..9585b10 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -176,7 +176,6 @@ define QT5BASE_CONFIGURE_CMDS
                -sysroot $(STAGING_DIR) \
                -plugindir /usr/lib/qt/plugins \
                -no-rpath \
-               -nomake examples -nomake tests \
                -device buildroot \
                -no-c++11 \
                $(QT5BASE_CONFIGURE_OPTS) \

And for some reason it tries to build the widgets/windowcontainer
example which depends on OpenGL. This is wrong since OpenGL is disabled.
I'm not sure what can be happening, since this example is not built in
my desktop (also non-OpenGL) Qt5 build.

Maybe you can take a look and fix? If you know the workaround to fix the
above I can try to push the patch myself.

Thanks!
-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com

  parent reply	other threads:[~2013-10-04 12:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20  5:43 [Buildroot] [PATCH v2 0/6] Bump Qt5 to version 5.1.1 Fatih Aşıcı
2013-09-20  5:43 ` [Buildroot] [PATCH v2 1/6] qt5: bump to 5.1.1 Fatih Aşıcı
2013-09-20  7:20   ` Espen Frimann Koren
2013-09-20  8:33     ` Fatih Aşıcı
2013-10-04 12:09   ` Ezequiel Garcia [this message]
2013-10-05 21:21     ` Fatih Aşıcı
2013-10-14 14:13   ` Ezequiel García
2013-10-26 17:09   ` Peter Korsgaard
2013-09-20  5:43 ` [Buildroot] [PATCH v2 2/6] qt5quickcontrols: new package Fatih Aşıcı
2013-10-26 17:10   ` Peter Korsgaard
2013-09-20  5:43 ` [Buildroot] [PATCH v2 3/6] qt5sensors: " Fatih Aşıcı
2013-10-26 17:10   ` Peter Korsgaard
2013-09-20  5:43 ` [Buildroot] [PATCH v2 4/6] qt5serialport: " Fatih Aşıcı
2013-10-26 17:10   ` Peter Korsgaard
2013-09-20  5:43 ` [Buildroot] [PATCH v2 5/6] qt5x11extras: " Fatih Aşıcı
2013-10-26 17:10   ` Peter Korsgaard
2013-09-20  5:43 ` [Buildroot] [PATCH v2 6/6] qt5: remove configure options from module packages Fatih Aşıcı
2013-09-20 14:52   ` Thomas Petazzoni
2013-10-09 21:15   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131004120957.GA5127@localhost \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox