From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 8 Oct 2013 14:16:02 +0200 Subject: [Buildroot] [PATCH v2] Add new package espeak, a speech synthesizer software In-Reply-To: <1381228089-3151-1-git-send-email-arnaud.aujon@gmail.com> References: <1381228089-3151-1-git-send-email-arnaud.aujon@gmail.com> Message-ID: <20131008141602.6a2dd858@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear arnaud.aujon at gmail.com, On Tue, 8 Oct 2013 12:28:09 +0200, arnaud.aujon at gmail.com wrote: > From: Arnaud Aujon > > Signed-off-by: Arnaud Aujon Thanks, it looks better since the patch is no longer wrapped, but other than that, you haven't taken into account any of the comments I made in the review of the first version. Have you seen the comments I made at http://lists.busybox.net/pipermail/buildroot/2013-October/079804.html ? Look at the entire e-mail, my answer was spread in the different parts of the e-mail, depending on what the comment was referring to. Also, your previous commit title was better, it should be just: espeak: new package Thanks Thomas -- Thomas Petazzoni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com