Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] protobuf-c: needs thread support
Date: Thu, 10 Oct 2013 10:44:27 +0300	[thread overview]
Message-ID: <20131010074427.GA4875@tarshish> (raw)
In-Reply-To: <1381389916.8952.2.camel@phoenix>

Hi Axel,

On Thu, Oct 10, 2013 at 03:25:16PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  package/protobuf-c/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/protobuf-c/Config.in b/package/protobuf-c/Config.in
> index 9aff6e2..17cc8f1 100644
> --- a/package/protobuf-c/Config.in
> +++ b/package/protobuf-c/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PROTOBUF_C
>  	bool "protobuf-c"
>  	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf

This should be squashed into the previous patch. Although strictly speaking 
bisectability is not broken by the previous patch (build without threads is 
broken already), it is nicer IMO.

baruch

>  	select BR2_PACKAGE_PROTOBUF
>  	help
>  	  Code generator and runtime libraries to use Protocol Buffers
> @@ -8,5 +9,5 @@ config BR2_PACKAGE_PROTOBUF_C
>  
>  	  http://code.google.com/p/protobuf-c/
>  
> -comment "protobuf-c requires a toolchain with C++ support enabled"
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +comment "protobuf-c requires a toolchain with C++ and thread support"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2013-10-10  7:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10  7:23 [Buildroot] [PATCH 1/2] protobuf: needs thread support Axel Lin
2013-10-10  7:25 ` [Buildroot] [PATCH 2/2] protobuf-c: " Axel Lin
2013-10-10  7:44   ` Baruch Siach [this message]
2013-10-10 20:42   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010074427.GA4875@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox