From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] ccache: expose control interface via 'make ccache-options'
Date: Thu, 10 Oct 2013 22:57:29 +0200 [thread overview]
Message-ID: <20131010225729.10b89fde@skate> (raw)
In-Reply-To: <CAEvN+1gw9BF6tcATOFJeoRLvVXrR2U7y3jO_KSMhNyz5Ka8Zmg@mail.gmail.com>
Dear Tzu-Jung Lee,
On Thu, 10 Oct 2013 12:51:27 -0700, Tzu-Jung Lee wrote:
> > Did you see my other comment about combining the ifeq statements of
> > ccache-stats and ccache-options?
>
> Yes, but I think it probably would be better as a separate patch,
> which:
>
> 1. either remove the ccache-stats code & and manual section
> 2. or issue warning about the obsolete usage.
>
> So this patch alone don't affect those are currently using
> ccache-stats before they migrate to ccache-options.
I believe there might be a misunderstanding here. You seem to think
Thomas suggested to remove ccache-stats because ccache-options now
allows to do the same.
But in fact, Thomas only suggested to change:
"""
ifeq ($(BR2_CCACHE),y)
ccache-stats:
...
endif
ifeq ($(BR2_CCACHE),y)
ccache-options:
...
endif
"""
by
"""
ifeq ($(BR2_CCACHE),y)
ccache-stats:
...
ccache-options:
...
endif
"""
i.e, ccache-stats continues to exist, the only difference with your
implementation is that it sits under the same ifeq ($(BR2_CCACHE),y)
condition. It's just a minor nit.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-10 20:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 3:50 [Buildroot] [PATCH 1/1] ccache: expose control interface via 'make ccache-options' Tzu-Jung Lee
2012-06-19 12:51 ` Tzu-Jung Lee
[not found] ` <CAEvN+1jCAvFYsOkbv4Rf4g7YqZJe4Ty9cwpFMiAUTTAvh7mvQg@mail.gmail.com>
2013-10-07 22:09 ` Tzu-Jung Lee
2013-10-08 6:46 ` Arnout Vandecappelle
2013-10-08 21:31 ` [Buildroot] [PATCH v2] " Tzu-Jung Lee
2013-10-09 6:55 ` Thomas De Schampheleire
2013-10-09 17:18 ` [Buildroot] [PATCH v3] " Tzu-Jung Lee
2013-10-10 7:12 ` Thomas Petazzoni
2013-10-10 7:59 ` Thomas De Schampheleire
2013-10-10 17:50 ` [Buildroot] [PATCH v4] " Tzu-Jung Lee
2013-10-10 19:45 ` Thomas De Schampheleire
2013-10-10 19:51 ` Tzu-Jung Lee
2013-10-10 20:57 ` Thomas Petazzoni [this message]
2013-10-10 21:01 ` Tzu-Jung Lee
2013-10-10 21:05 ` Thomas Petazzoni
2013-10-11 4:52 ` Thomas De Schampheleire
2013-10-27 9:34 ` Peter Korsgaard
2013-10-08 7:11 ` [Buildroot] [PATCH 1/1] " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010225729.10b89fde@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox