From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] support/kconfig: fix compile warning because of missing include.
Date: Thu, 10 Oct 2013 22:59:39 +0200 [thread overview]
Message-ID: <20131010225939.03febe7a@skate> (raw)
In-Reply-To: <1381429615-6689-1-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On Thu, 10 Oct 2013 20:26:55 +0200, Peter Seiderer wrote:
> With commit b58bf60b519353e983e372f5627d639e7cc72a7a the libgen.h
> include was removed from confdata.c, but it is needed for the dirname
> function declaration.
>
> Fixes the following compile warning:
> ./confdata.c: In function ?conf_split_config?:
> ./confdata.c:849:6: warning: assignment makes pointer from integer
> without a cast
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Yes, this warning is annoying. However, we should not simply modify
kconfig code directly, the patches in support/kconfig/patches/ have to
be updated accordingly: they must contain *all* the changes that we
have applied on top of the kernel version of kconfig. This is needed
because when regularly update the kconfig code in support/kconfig/
using the latest one from the kernel. And if we want to do this without
losing our own changes, we must keep the patches in
support/kconfig/patches/ accurate.
Could you fix your patch so that it also includes a new patch in
support/kconfig/patches/ (or modifies one of the existing patch if it
makes more sense).
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-10-10 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 18:26 [Buildroot] [PATCH 1/1] support/kconfig: fix compile warning because of missing include Peter Seiderer
2013-10-10 20:59 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010225939.03febe7a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox