From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sat, 12 Oct 2013 12:23:13 +0200
Subject: [Buildroot] [PATCH v2] uboot: support -r option for mkenvimage
In-Reply-To: <1381572339-3232-1-git-send-email-spdawson@gmail.com>
References: <1381572339-3232-1-git-send-email-spdawson@gmail.com>
Message-ID: <20131012122313.44d65734@skate>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Simon,

On Sat, 12 Oct 2013 11:05:39 +0100, spdawson at gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
> 
> Some boards are configured in u-boot to store multiple redundant copies of
> the environment image in flash. For these boards, it is required to pass the -r
> flag, when generating a boot environment image using mkenvimage.
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>  v2: Change configuration menu text and help text, in response to feedback
>      from Arnout Vandecappelle and Thomas Petazzoni
> 
>  boot/uboot/Config.in | 8 ++++++++
>  boot/uboot/uboot.mk  | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index 998cda2..b750c77 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -242,6 +242,14 @@ config BR2_TARGET_UBOOT_ENVIMAGE_SIZE
>  	  Size of envronment, can be prefixed with 0x for hexadecimal
>  	  values.
>  
> +config BR2_TARGET_UBOOT_ENVIMAGE_REDUNDANT
> +	bool "Environment has two copies"
> +	help
> +	  There are two copies of the environment in flash.
> +
> +	  Check your u-boot configuration for the CONFIG_ENV_ADDR_REDUND and
> +	  CONFIG_ENV_SIZE_REDUND settings.

I'm sorry but I'm still unhappy with the help text, especially since
your commit log is in fact better :-)

	  Some platforms define in their U-Boot configuration that the
	  U-Boot environment should be duplicated in two locations (for
	  extra safety). Check your U-Boot configuration for the
	  CONFIG_ENV_ADDR_REDUND and CONFIG_ENV_SIZE_REDUND settings to
	  see if it is the case for your platform.

	  If it is the case, then you should enable this option to
	  ensure that the U-Boot environment image generated by
	  Buildroot is compatible with this "redundant environment"
	  mechanism of U-Boot.

Or something along those lines (don't hesitate to fix the broken
english if needed).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com