From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ruby: fix 'pcrel too far' build problem on SuperH architectures
Date: Sun, 13 Oct 2013 09:51:40 +0200 [thread overview]
Message-ID: <20131013095140.7a9e70e5@skate> (raw)
In-Reply-To: <873298952161de3ed5aa.1381650276@argentina>
Dear Thomas De Schampheleire,
On Sun, 13 Oct 2013 09:44:36 +0200, Thomas De Schampheleire wrote:
> +# With some SuperH toolchains (like Sourcery CodeBench 2012.09), ruby fails to
> +# build with 'pcrel too far'. This seems to be caused by the -Os option we pass
> +# by default. To fix the problem, use standard -O2 optimization instead.
> +ifeq ($(BR2_sh)$(BR2_sh64),y)
> +TARGET_CFLAGS += -O2
> +endif
I don't think it's the right way of fixing the problem. This is going to
affect the CFLAGS of *all* packages. You shouldn't change
TARGET_CFLAGS, but instead do:
RUBY_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O2"
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-13 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 7:44 [Buildroot] [PATCH] ruby: fix 'pcrel too far' build problem on SuperH architectures Thomas De Schampheleire
2013-10-13 7:51 ` Thomas Petazzoni [this message]
2013-10-13 7:58 ` Thomas De Schampheleire
2013-10-13 8:25 ` Thomas Petazzoni
2013-10-13 10:38 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131013095140.7a9e70e5@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox