Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain-external: add a specific check to avoid Angstrom toolchains
Date: Sun, 13 Oct 2013 15:41:06 +0200	[thread overview]
Message-ID: <20131013154106.0f3c049d@skate> (raw)
In-Reply-To: <20131013124803.2044e4c3@e6520eb>

Dear Eric B?nard,

On Sun, 13 Oct 2013 12:48:03 +0200, Eric B?nard wrote:

> Le Sat, 12 Oct 2013 12:14:42 +0200,
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
> > To avoid this problem in the future, we explicitly check if the
> > toolchain is from Angstrom by looking at the vendor part of the tuple
> > exposed by the toolchain: as soon as it is
> > <something>-angstrom-<something-else>, we reject the toolchain with an
> > explanation.
> > 
> maybe you should also check for at least "oe" and "poky" as these are
> the vendor part of toolchains generated with plain OE-Core or
> Yocto/Poky.

Hum, right. Are those available in the form of tarballs, like the
angstrom toolchain available at
http://www.angstrom-distribution.org/toolchains/ ? I know you can
generate such tarballs with OE or Yocto, but unless these tarballs are
available pre-built on the web, I guess it's pretty unlikely that such
toolchains get used as external toolchains in Buildroot.

Ideally, we would need to check if the toolchain is not a pure
toolchain, but it's quite hard to check. We would have to verify if the
toolchain does *not* have more than what it should have, but doing that
in an exhaustive way is quite difficult.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-10-13 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-12 10:14 [Buildroot] [PATCH] toolchain-external: add a specific check to avoid Angstrom toolchains Thomas Petazzoni
2013-10-12 10:19 ` Yann E. MORIN
2013-10-13  7:29 ` Thomas De Schampheleire
2013-10-13 10:48 ` Eric Bénard
2013-10-13 13:41   ` Thomas Petazzoni [this message]
2013-10-13 13:50     ` Eric Bénard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131013154106.0f3c049d@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox