From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] trace-cmd: use pkg-config instead of python-config
Date: Mon, 14 Oct 2013 08:58:03 +0200 [thread overview]
Message-ID: <20131014085803.4c139478@skate> (raw)
In-Reply-To: <525B1E2E.2040209@openwide.fr>
Dear Romain Naour,
On Mon, 14 Oct 2013 00:26:54 +0200, Romain Naour wrote:
>
> Add missing python dependency.
> Makefile use host's python-config, which seems breaks powerpc and arm build.
> Replaces python-config with pkg-config.
> Add pkg-config as dependency.
>
> Fixes:
> http://autobuild.buildroot.net/results/980/980875810528ac1dee34b8c268d9b3c40b2e35ec/
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Interesting, this looks simpler than what I have done.
> ---
> Note: Makefile use swig which is not available in buildroot.
swig is definitely available, in package/swig/.
>
> package/trace-cmd/Config.in | 2 ++
> ...e-use-pkg-config-instead-of-python-config.patch | 34 ++++++++++++++++++++++
> package/trace-cmd/trace-cmd.mk | 2 ++
> 3 files changed, 38 insertions(+)
> create mode 100644 package/trace-cmd/trace-cmd-0001-Makefile-use-pkg-config-instead-of-python-config.patch
>
> diff --git a/package/trace-cmd/Config.in b/package/trace-cmd/Config.in
> index 8d79304..96ed63a 100644
> --- a/package/trace-cmd/Config.in
> +++ b/package/trace-cmd/Config.in
> @@ -2,6 +2,8 @@ config BR2_PACKAGE_TRACE_CMD
> bool "trace-cmd"
> depends on BR2_LARGEFILE
> depends on BR2_TOOLCHAIN_HAS_THREADS
> + select BR2_PACKAGE_PYTHON
No, Python support is optional in trace-cmd. We should keep optional,
by doing:
ifeq ($(BR2_PACKAGE_PYTHON),)
TRACE_CMD_MAKE_FLAGS += -NO_PYTHON=1
else
TRACE_CMD_DEPENDENCIES += python
endif
> + select BR2_PACKAGE_PKG_CONFIG
No, this is wrong. The pkg-config you're using is not the target
pkg-config, but the host pkg-config. There is no need to add a
Config.in dependency for that.
> diff --git a/package/trace-cmd/trace-cmd.mk b/package/trace-cmd/trace-cmd.mk
> index 7a750f9..cd6ba20 100644
> --- a/package/trace-cmd/trace-cmd.mk
> +++ b/package/trace-cmd/trace-cmd.mk
> @@ -11,6 +11,8 @@ TRACE_CMD_INSTALL_STAGING = YES
> TRACE_CMD_LICENSE = GPLv2 LGPLv2.1
> TRACE_CMD_LICENSE_FILES = COPYING COPYING.LIB
>
> +TRACE_CMD_DEPENDENCIES = python pkg-config
Python dependency should be optional. The pkg-config dependency should
be on host-pkg-config.
See also the patch set I had posted to fix the same issue (in a
different way, which required changing python2 and python3 config
scripts):
http://patchwork.ozlabs.org/patch/279267/
http://patchwork.ozlabs.org/patch/279265/
http://patchwork.ozlabs.org/patch/279269/
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-14 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 22:26 [Buildroot] [PATCH 1/1] trace-cmd: use pkg-config instead of python-config Romain Naour
2013-10-14 6:58 ` Thomas Petazzoni [this message]
2013-10-14 10:52 ` Peter Korsgaard
2013-10-14 22:39 ` Romain Naour
2013-10-15 7:30 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014085803.4c139478@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox