From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] git packages and revision number length
Date: Wed, 23 Oct 2013 14:24:47 +0200 [thread overview]
Message-ID: <20131023142447.7d45e0d3@skate> (raw)
In-Reply-To: <CAAXf6LUjx9RjkCQDbO+O3EZfFPPYNW-5hQUpANG9jCgekokbpw@mail.gmail.com>
Dear Thomas De Schampheleire,
On Wed, 23 Oct 2013 13:54:01 +0200, Thomas De Schampheleire wrote:
> I disagree with that. The first 7 characters do not guarantee that a
> few years from now their will not be an ambiguity in that project,
> where two revisions have the same 7 initial characters.
>
> Shortened revision numbers are great in communication (verbal, mail,
> IRC, ...) but should not be committed in a build system that is
> supposed to create reproducible builds over a long-term lifespan.
>
> We can start discussing statistics, about how many years it takes on
> average for a clash to occur with a given revision number length, but
> the fact is that it is possible to have a clash by tomorrow. Only the
> chances are much smaller with increasing lengths.
>
> So I propose to change that recommendation (and the packages that use
> it) and use the full 40-hex-char revision numbers.
I agree with you, especially since using reduced 7-hex-char revision
numbers over full 40-hex-char revision numbers doesn't bring any
specific advantage. Using full hashes doesn't hurt, and is more
future-proof so let's do it.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-10-23 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:54 [Buildroot] git packages and revision number length Thomas De Schampheleire
2013-10-23 12:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023142447.7d45e0d3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox