From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] hplip: bump to version 3.13.10
Date: Wed, 30 Oct 2013 22:16:44 +0100 [thread overview]
Message-ID: <20131030221644.28f0d77a@skate> (raw)
In-Reply-To: <1383165435-14305-1-git-send-email-olivier.schonken@gmail.com>
Dear Olivier Schonken,
On Wed, 30 Oct 2013 22:37:15 +0200, Olivier Schonken wrote:
> # ui (qt3)
> -@@ -564,26 +564,26 @@ endif
> -
> - install-dist_hplip_LogDATA:
> - if FULL_BUILD
> -- test -z "$(DESTDIR)$(hplip_Logdir)" || mkdir -p $(DESTDIR)$(hplip_Logdir)
> -- chgrp "lp" -R $(DESTDIR)$(hplip_Logdir)
> -- chmod 775 $(DESTDIR)$(hplip_Logdir)
> -+# test -z "$(DESTDIR)$(hplip_Logdir)" || mkdir -p $(DESTDIR)$(hplip_Logdir)
> -+# chgrp "lp" -R $(DESTDIR)$(hplip_Logdir)
> -+# chmod 775 $(DESTDIR)$(hplip_Logdir)
> - endif #FULL_BUILD
> - if HPLIP_BUILD
> -- test -z "$(DESTDIR)$(hplip_Logdir)" || mkdir -p $(DESTDIR)$(hplip_Logdir)
> -- chgrp "lp" -R $(DESTDIR)$(hplip_Logdir)
> -- chmod 775 $(DESTDIR)$(hplip_Logdir)
> -+# test -z "$(DESTDIR)$(hplip_Logdir)" || mkdir -p $(DESTDIR)$(hplip_Logdir)
> -+# chgrp "lp" -R $(DESTDIR)$(hplip_Logdir)
> -+# chmod 775 $(DESTDIR)$(hplip_Logdir)
> - endif #FULL_BUILD
> -
> - install-dist_hplip_tmpDATA:
> - if FULL_BUILD
> -- test -z "$(DESTDIR)$(hplip_tmpdir)" || mkdir -p $(DESTDIR)$(hplip_tmpdir)
> -- chgrp "lp" -R $(DESTDIR)$(hplip_tmpdir)
> -- chmod 1775 $(DESTDIR)$(hplip_tmpdir)
> -+# test -z "$(DESTDIR)$(hplip_tmpdir)" || mkdir -p $(DESTDIR)$(hplip_tmpdir)
> -+# chgrp "lp" -R $(DESTDIR)$(hplip_tmpdir)
> -+# chmod 1775 $(DESTDIR)$(hplip_tmpdir)
> - endif #FULL_BUILD
> - if HPLIP_BUILD
> -- test -z "$(DESTDIR)$(hplip_tmpdir)" || mkdir -p $(DESTDIR)$(hplip_tmpdir)
> -- chgrp "lp" -R $(DESTDIR)$(hplip_tmpdir)
> -- chmod 1775 $(DESTDIR)$(hplip_tmpdir)
> -+# test -z "$(DESTDIR)$(hplip_tmpdir)" || mkdir -p $(DESTDIR)$(hplip_tmpdir)
> -+# chgrp "lp" -R $(DESTDIR)$(hplip_tmpdir)
> -+# chmod 1775 $(DESTDIR)$(hplip_tmpdir)
> - endif #FULL_BUILD
> -
> - install-dist_cronDATA:$(dist_cron_DATA)
Thanks for this patch. Would you mind giving a few more details on the
reason for removing those lines? They are no longer present in the
upstream Makefile? Something else?
Generally speaking, when a version bump comes with other changes (like
changes to patches), it's good to describe them a little bit.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-10-30 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 20:37 [Buildroot] [PATCH 1/1] hplip: bump to version 3.13.10 Olivier Schonken
2013-10-30 21:16 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030221644.28f0d77a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox