From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/5] util-linux: Fix cross-compile for host-util-linux when ncurses not selected
Date: Wed, 30 Oct 2013 22:18:59 +0100 [thread overview]
Message-ID: <20131030221859.0e7f43f6@skate> (raw)
In-Reply-To: <1383164412-20657-5-git-send-email-olivier.schonken@gmail.com>
Dear Olivier Schonken,
On Wed, 30 Oct 2013 22:20:12 +0200, Olivier Schonken wrote:
> +ifeq ($(BR2_PACKAGE_NCURSES),y)
> +HOST_UTIL_LINUX_DEPENDENCIES += ncurses
> +else
> +HOST_UTIL_LINUX_CONF_OPT += --without-ncurses
> +endif
This cannot be correct. BR2_PACKAGE_NCURSES tells whether ncurses is
enabled for the target, but you're using that to decide how to
configure the host util-linux.
Since I believe we most likely don't need ncurses support at all in the
host util-linux, we can unconditionally add a --without-ncurses to
HOST_UTIL_LINUX_CONF_OPT. Could you resend an updated patch that
implements this?
Also, it would be good if you could improve the commit log by adding
the relevant piece of build log containing the util-linux configure
error.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-10-30 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 20:20 [Buildroot] [PATCH 1/5] liburcu: bump to version 0.8.0 Olivier Schonken
2013-10-30 20:20 ` [Buildroot] [PATCH 2/5] lttng-tools: bump to version 2.3.0 Olivier Schonken
2013-10-30 20:20 ` [Buildroot] [PATCH 3/5] lttng-modules: bump to version 2.3.2 Olivier Schonken
2013-10-30 20:20 ` [Buildroot] [PATCH 4/5] lttng-libust: bump to version 2.3.0 Olivier Schonken
2013-10-30 20:20 ` [Buildroot] [PATCH 5/5] util-linux: Fix cross-compile for host-util-linux when ncurses not selected Olivier Schonken
2013-10-30 21:18 ` Thomas Petazzoni [this message]
2013-10-31 7:29 ` Olivier Schonken
2013-10-31 7:40 ` Thomas Petazzoni
2013-11-02 17:41 ` [Buildroot] [PATCH 1/5] liburcu: bump to version 0.8.0 Thomas Petazzoni
2013-11-03 20:32 ` Olivier Schonken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030221859.0e7f43f6@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox