From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] ngrep: fix static linking issue with libpcre
Date: Fri, 1 Nov 2013 17:59:57 +0100 [thread overview]
Message-ID: <20131101175957.689162a5@skate> (raw)
In-Reply-To: <5255D08E.3000307@openwide.fr>
Dear Romain Naour,
On Wed, 09 Oct 2013 23:54:22 +0200, Romain Naour wrote:
>
> Adding -lpcre in LDFLAGS place the library before object files:
> gcc ... -lpcre -L .../sysroot/usr/lib -s -o ngrep ngrep.o -lpcap
>
> Makefile.in is patched to use @LIBS@ for adding -lpcre in the right place.
>
> Fixes:
> http://autobuild.buildroot.net/results/684/684a3bed28d13ef5e5156257aade3b9aff32f180
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Thanks, but this patch no longer applies on top of master, and more
importantly, the ngrep-1.45-Makefile.in.patch doesn't apply to the
ngrep sources. Could you rename the ngrep patches to use numbers, i.e
ngrep-01-<foo>.patch, and use a more descriptive name than
ngrep-1.45-Makefile.in.patch?
(Should be done in two patches: one renaming the existing patches, one
adding the pcre static link fix).
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-01 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:54 [Buildroot] [PATCH v2 1/1] ngrep: fix static linking issue with libpcre Romain Naour
2013-11-01 16:59 ` Thomas Petazzoni [this message]
2013-11-02 15:46 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101175957.689162a5@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox