From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] dhcpcd: needs MMU
Date: Sat, 2 Nov 2013 18:59:14 +0100 [thread overview]
Message-ID: <20131102175914.GH3542@free.fr> (raw)
In-Reply-To: <1383400021-16905-1-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2013-11-02 14:47 +0100, Thomas Petazzoni spake thusly:
> dhcpcd fails to build on non-MMU platforms, even with the
> --disable-fork option:
>
> bind.o: In function `_daemonise':
> bind.c:(.text+0x62): undefined reference to `_fork'
> collect2: ld returned 1 exit status
>
> Therefore, we make dhcpcd depend on MMU support, and remove the
> non-MMU condition in the .mk file. More recent versions of dhcpcd do
> support non-MMU properly, but this commit intends to be only a fix.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> v1 -> v2: remove non-MMU condition in .mk file, mentionned by Gustavo.
> ---
> package/dhcpcd/Config.in | 1 +
> package/dhcpcd/dhcpcd.mk | 4 ----
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/package/dhcpcd/Config.in b/package/dhcpcd/Config.in
> index dbde548..ddbc6f4 100644
> --- a/package/dhcpcd/Config.in
> +++ b/package/dhcpcd/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_DHCPCD
> depends on BR2_INET_IPV6
> + depends on BR2_USE_MMU # fork()
> bool "dhcpcd"
> help
> An RFC2131 compliant DHCP client
> diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
> index 5296db8..13810f3 100644
> --- a/package/dhcpcd/dhcpcd.mk
> +++ b/package/dhcpcd/dhcpcd.mk
> @@ -9,10 +9,6 @@ DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.bz2
> DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd/
> DHCPCD_LICENSE = BSD-2c
>
> -ifeq ($(BR2_USE_MMU),)
> - DHCPCD_CONFIG_OPT += --disable-fork
> -endif
> -
> define DHCPCD_CONFIGURE_CMDS
> (cd $(@D); \
> ./configure \
> --
> 1.8.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-11-02 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 13:47 [Buildroot] [PATCHv2] dhcpcd: needs MMU Thomas Petazzoni
2013-11-02 17:59 ` Yann E. MORIN [this message]
2013-11-02 18:01 ` Samuel Martin
2013-11-02 18:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131102175914.GH3542@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox