From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: fix out-of-tree builds with multiple targets with 'all'
Date: Sun, 3 Nov 2013 11:24:04 +0100 [thread overview]
Message-ID: <20131103102404.GA3615@free.fr> (raw)
In-Reply-To: <1383473902-27845-1-git-send-email-yann.morin.1998@free.fr>
Hello All,
On 2013-11-03 11:18 +0100, Yann E. MORIN spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> For out-of-tree builds, this use-case fails to build:
> $ make clean all
>
> This is because 'all' is filtered-out in the Makefile wrapper, since
> the wrapper itself has a 'all' target.
>
> The 'all' target is just the usual naming for the default target in a
> Makefile. In fact, the first target is the default one, so we can name
> it whatever we want.
>
> Rename the Makefile wrapper 'all' target to avoid name-clashing.
Sorry, I forgot one occurence of 'all'. New patch on its way...
Regards,
Yann E. MORIN.
> Reported-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Ryan Barnett <rjbarnet@rockwellcollins.com>
> ---
> support/scripts/mkmakefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile
> index cef2ec7..89dc649 100755
> --- a/support/scripts/mkmakefile
> +++ b/support/scripts/mkmakefile
> @@ -32,14 +32,14 @@ MAKEFLAGS += --no-print-directory
>
> .PHONY: all \$(MAKECMDGOALS)
>
> -all := \$(filter-out all Makefile,\$(MAKECMDGOALS))
> +all := \$(filter-out Makefile,\$(MAKECMDGOALS))
>
> -all:
> +_all:
> \$(MAKE) \$(MAKEARGS) \$(all)
>
> Makefile:;
>
> -\$(all): all
> +\$(all): _all
> @:
>
> %/: all
> --
> 1.8.1.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-11-03 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-03 10:18 [Buildroot] [PATCH] Makefile: fix out-of-tree builds with multiple targets with 'all' Yann E. MORIN
2013-11-03 10:24 ` Yann E. MORIN [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-11-05 18:33 Yann E. MORIN
2013-11-05 18:39 ` Thomas De Schampheleire
2013-11-05 18:48 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131103102404.GA3615@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox