From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 7 Nov 2013 00:13:43 +0100 Subject: [Buildroot] [PATCH] gcc: use generic infrastructure for patches In-Reply-To: <1383778795-15262-1-git-send-email-arnout@mind.be> References: <527AB58A.9050506@mind.be> <1383778795-15262-1-git-send-email-arnout@mind.be> Message-ID: <20131107001343.7f90de1c@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Arnout Vandecappelle (Essensium/Mind), On Wed, 6 Nov 2013 23:59:55 +0100, Arnout Vandecappelle (Essensium/Mind) wrote: > package/gcc/gcc-final/4.2.2-avr32-2.1.5 | 1 + > package/gcc/gcc-final/4.3.6 | 1 + > package/gcc/gcc-final/4.4.7 | 1 + > package/gcc/gcc-final/4.5.4 | 1 + > package/gcc/gcc-final/4.6.4 | 1 + > package/gcc/gcc-final/4.7.3 | 1 + > package/gcc/gcc-final/4.8-arc | 1 + > package/gcc/gcc-final/4.8.2 | 1 + The only problem that I see with this symbolic link based solution is that we will have to remember to add/update the three symbolic each time we do a gcc version bump. If we forget to do so, then the build will go on silently, but without having applied the patches. I don't say this problem is a show-stopper, but it's a drawback of this symbolic link solution, IMO. > define HOST_GCC_APPLY_POWERPC_PATCH > - support/scripts/apply-patches.sh $(@D) package/gcc/$(GCC_VERSION) powerpc-link-with-math-lib.patch.conditional > + if [ -e package/gcc/$(GCC_VERSION)/powerpc-link-with-math-lib.patch.conditional ]; then \ > + support/scripts/apply-patches.sh $(@D) package/gcc/$(GCC_VERSION) powerpc-link-with-math-lib.patch.conditional; \ > + fi Why was adding the condition necessary? Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com