From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 11 Nov 2013 11:21:28 +0100 Subject: [Buildroot] [PATCH] alsa-lib: FLAT: Disable alsa lib when FLAT bianry is selected. In-Reply-To: <1384146177-6020-1-git-send-email-Sonic.adi@gmail.com> References: <1384146177-6020-1-git-send-email-Sonic.adi@gmail.com> Message-ID: <20131111112128.60a4a348@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Mon, 11 Nov 2013 13:02:57 +0800, sonic.adi at gmail.com wrote: > From: Sonic Zhang > > Alsa lib depends on the runtime library loader. > > Signed-off-by: Sonic Zhang > --- > package/alsa-lib/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/alsa-lib/Config.in b/package/alsa-lib/Config.in > index df05240..1e148cc 100644 > --- a/package/alsa-lib/Config.in > +++ b/package/alsa-lib/Config.in > @@ -9,6 +9,7 @@ config BR2_PACKAGE_ALSA_LIB > # the usage of alsa-lib on no-thread systems is pretty > # unlikely, just require thread support globally for alsa-lib. > depends on BR2_TOOLCHAIN_HAS_THREADS > + depends on !BR2_BINFMT_FLAT I am not sure this is the right dependency. Shouldn't this instead be a: depends on !BR2_PREFER_STATIC_LIB ? The problem is really that we need shared library support, no that specifically the FLAT binary format is causing problems. If another binary format doesn't support shared libraries, then we would have to exclude it as well. Also, the configure script of alsa-lib has a check to verify if dlfcn.h is available or not, so I guess it is supposed to fallback gracefully to another solution if shared library support is not available. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com