Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pkg-luarocks infra V3 01/10] luainterpreter: create virtual package
Date: Fri, 15 Nov 2013 09:44:23 +0100	[thread overview]
Message-ID: <20131115094423.024e1af8@skate> (raw)
In-Reply-To: <CAAXf6LXVQ8uFccP2+-TwQOC0iAH=ochrtzUQH-sFN7sZetrpUQ@mail.gmail.com>

Dear Thomas De Schampheleire,

On Fri, 15 Nov 2013 08:24:59 +0100, Thomas De Schampheleire wrote:

> >  config BR2_PACKAGE_LBASE64
> >         bool "lbase64"
> > +       depends on BR2_PACKAGE_HAS_LUA_INTERPRETER
> >         help
> >           A base64 library for Lua
> 
> The meaning of BR2_PACKAGE_HAS_LUA_INTERPRETER is that the user has
> selected one of lua or luajit, right?
> Is the PACKAGE in there really needed? What about
> BR2_HAS_LUA_INTERPRETER instead? This says that 'buildroot has a lua
> interpreter' and not that 'a package has a lua interpreter'.

On the other hand, we have:

 BR2_PACKAGE_HAS_OPENGL_EGL
 BR2_PACKAGE_HAS_OPENGL_ES
 BR2_PACKAGE_HAS_OPENVG
 BR2_PACKAGE_HAS_OPENMAX
 BR2_PACKAGE_HAS_POWERVR


> > +++ b/package/luainterpreter/luainterpreter.mk
> > @@ -0,0 +1,18 @@
> > +#############################################################
> > +#
> > +# Virtual package for luainterpreter
> > +#
> > +#############################################################
> > +
> > +LUAINTERPRETER_VERSION = 5.1
> 
> What is the meaning of this version? It seems to be the lua version,
> but is this relevant for a virtual package?

No, it is not relevant. Maybe we could have the policy of doing:

<foo>_VERSION = virtual
<foo>_SOURCE =

for virtual packages. This way instead of showing "unknown" in the ">>>
blabla unknown extracting" messages, we would have ">>> blabla virtual
extracting".

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-11-15  8:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 20:17 [Buildroot] [pkg-luarocks infra V3 01/10] luainterpreter: create virtual package Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 02/10] luajit: allow to build Lua extensions without lua Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 03/10] lua: remove a too invasive patch Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 04/10] lua*: restore version in module paths Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 05/10] luarocks: new package Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 06/10] luarocks: new infrastructure Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 07/10] lua-cjson: restore official name Francois Perrad
2013-11-15  7:47   ` Thomas De Schampheleire
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 08/10] luasql-sqlite3: renamed like with LuaRocks Francois Perrad
2013-11-15  7:49   ` Thomas De Schampheleire
2013-11-15  8:20     ` Thomas Petazzoni
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 09/10] lua*: refactor with luarocks infrastructure Francois Perrad
2013-11-14 20:17 ` [Buildroot] [pkg-luarocks infra V3 10/10] manual: adding packages luarocks Francois Perrad
2013-11-15  7:24 ` [Buildroot] [pkg-luarocks infra V3 01/10] luainterpreter: create virtual package Thomas De Schampheleire
2013-11-15  8:44   ` Thomas Petazzoni [this message]
2013-11-15  9:11     ` Thomas De Schampheleire
2013-11-15  9:18       ` Thomas Petazzoni
2013-11-15  9:49         ` Thomas De Schampheleire
2013-11-15 12:56           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115094423.024e1af8@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox