Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Ruder <andrew.ruder@elecsyscorp.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wvstreams: remove tcl dependency support
Date: Fri, 15 Nov 2013 08:45:28 -0600	[thread overview]
Message-ID: <20131115144528.GA1086@gmail.com> (raw)
In-Reply-To: <20131114225758.GA13765@gmail.com>

Simon,

I mistakingly left you off the original e-mail.  Any chance you could
review the sanity of this patch?  As best as I can tell, the TCL support
is some holdover from an earlier version of wvstreams (I can't find any
references to the HAVE_TCL_H and friends in the source code) and never
linked properly anyway as wvstreams only looks for tcl 8.3.  I only came
across it as I am trying to bump tcl and started looking at packages
with tcl dependencies and found this one.

I actually have a similar patch that fixes it to find/link against tcl
8.4 or tcl 8.6 but that's when I started digging around to see what it
actually changed in the source code and never could find anything and
went with this patch instead.

Thanks,
Andy


----------

As far as I can tell enabling tcl support has no affect on the actual
library.  Furthermore, wvstreams has been checking for/linking against
tcl 8.3 which has never been supported in buildroot as far as I can tell
(8.4 added in 2005).  That being said there is clearly no reason to keep
this around.

Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com>
---

 On a side-note, I am testing a few bigger patches to get expect 5.45
 and tcl 8.6.1 added/bumped.  I haven't done a decent amount of testing,
 but figured I'd get some of the smaller patches out of the way as I go.

 package/wvstreams/wvstreams.mk | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/package/wvstreams/wvstreams.mk b/package/wvstreams/wvstreams.mk
index b4f7d89..41155a7 100644
--- a/package/wvstreams/wvstreams.mk
+++ b/package/wvstreams/wvstreams.mk
@@ -22,7 +22,8 @@ WVSTREAMS_CONF_OPT += \
 	--with-openssl \
 	--with-zlib \
 	--without-pam \
-	--disable-warnings
+	--disable-warnings \
+	--without-tcl
 
 # needed for openssl detection when statically linking (as ssl needs lz)
 WVSTREAMS_CONF_ENV += LIBS=-lz
@@ -38,13 +39,6 @@ else
 	WVSTREAMS_CONF_OPT += --without-dbus
 endif
 
-ifeq ($(BR2_PACKAGE_TCL),y)
-	WVSTREAMS_DEPENDENCIES += tcl
-	WVSTREAMS_CONF_OPT += --with-tcl
-else
-	WVSTREAMS_CONF_OPT += --without-tcl
-endif
-
 ifeq ($(BR2_PACKAGE_QT),y)
 	WVSTREAMS_DEPENDENCIES += qt
 	WVSTREAMS_CONF_OPT += --with-qt
-- 
1.8.4.rc3

  parent reply	other threads:[~2013-11-15 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 22:57 [Buildroot] [PATCH] wvstreams: remove tcl dependency support Andrew Ruder
2013-11-15  8:47 ` Thomas Petazzoni
2013-11-15 14:45 ` Andrew Ruder [this message]
2013-11-16  9:36   ` Simon Dawson
2013-11-17  7:49 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131115144528.GA1086@gmail.com \
    --to=andrew.ruder@elecsyscorp.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox