From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] dbus-python: select pyexpat dependency
Date: Tue, 19 Nov 2013 00:32:45 +0100 [thread overview]
Message-ID: <20131119003245.29a4eb69@skate> (raw)
In-Reply-To: <CAPyrzo1JdOBrWPbDR3-B5CJXQi0O5nGoK_HQOQv6rWNYAMhJqg@mail.gmail.com>
Dear Ivan Sergeev,
On Mon, 18 Nov 2013 14:37:59 -0800, Ivan Sergeev wrote:
> For some reason git send-email didn't attach the patch. I've attached it
> here.
git send-email never "attaches" the patch. It sends the patch inline,
so that reviewers can hit "reply" and review your patch directly by
replying to the e-mail.
I think your patch is good, but you should add a comment above the new
select line to indicate that it is a runtime dependency only (which
explains why you're changing the Config.in only, and not the .mk file).
Something like:
# Runtime dependency only
select BR2_PACKAGE...
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-11-18 23:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 22:35 [Buildroot] [PATCH 1/1] dbus-python: select pyexpat dependency Ivan Sergeev
2013-11-18 22:37 ` Ivan Sergeev
2013-11-18 23:32 ` Thomas Petazzoni [this message]
2013-11-19 1:55 ` Ivan Sergeev
2013-11-19 2:10 ` Ivan Sergeev
2013-11-30 8:06 ` Peter Korsgaard
2013-11-18 23:17 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119003245.29a4eb69@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox