Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libnspr: Add dependency on !BR2_xtensa
Date: Wed, 27 Nov 2013 10:08:15 +0100	[thread overview]
Message-ID: <20131127100815.040fe17a@skate> (raw)
In-Reply-To: <20131127090215.GX32436@tarshish>

Dear Baruch Siach,

On Wed, 27 Nov 2013 11:02:15 +0200, Baruch Siach wrote:

> > Thanks! However, I wonder if it's not actually easier to include a
> > patch to libnspr to add Xtensa support. See
> > http://patchwork.ozlabs.org/patch/291080/ for a patch that adds
> > NIOS2 support, for example.
> 
> That would obviously be better, but I can't properly test a patch
> adding libnspr xtensa support at the moment. Note that xtensa has BE
> and LE variants, so it's a little more involved that the nios patch.
> 
> > That being said, I'm fine with having libnspr disabled on Xtensa,
> > as I don't believe that many people will care about
> > libnspr/libnss/ecryptfs-utils.
> 
> It seems like blackfin needs the same treatment 
> (http://autobuild.buildroot.net/results/dd353703ed94cec48cd126d80cd2f1b039811be4/).

Ok, then maybe we want something similar to what I've done for Qt:
http://git.buildroot.net/buildroot/commit/package/qt?id=01f99d284fd51bd149e7a92d0e9e7fc368cd0e99.
So a BR2_PACKAGE_LIBNSPR_ARCH_SUPPORTED hidden kconfig knob that is
only enabled for those architectures that support nspr. Therefore, when
we need to change which architectures are supported by nspr, we don't
have to go edit all the reverse dependencies of nspr.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2013-11-27  9:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  5:29 [Buildroot] [PATCH v2] libnspr: Add dependency on !BR2_xtensa Baruch Siach
2013-11-27  8:27 ` Thomas Petazzoni
2013-11-27  9:02   ` Baruch Siach
2013-11-27  9:08     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131127100815.040fe17a@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox