From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Sun, 1 Dec 2013 00:10:40 +0100 Subject: [Buildroot] [PATCHv4 5/5] manual: fix manual generation with BR2_EXTERNAL support In-Reply-To: <1385751626-28967-6-git-send-email-thomas.petazzoni@free-electrons.com> References: <1385751626-28967-1-git-send-email-thomas.petazzoni@free-electrons.com> <1385751626-28967-6-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <20131130231040.GE3500@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Samuel, All, On 2013-11-29 20:00 +0100, Thomas Petazzoni spake thusly: > From: Samuel Martin > > Reported-by: Ryan Barnett > Signed-off-by: Samuel Martin > Cc: Thomas Petazzoni > Signed-off-by: Ryan Barnett > Signed-off-by: Thomas Petazzoni > --- > docs/manual/manual.mk | 1 + > support/scripts/kconfiglib.py | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/manual/manual.mk b/docs/manual/manual.mk > index aeafd10..570318f 100644 > --- a/docs/manual/manual.mk > +++ b/docs/manual/manual.mk > @@ -1,6 +1,7 @@ > manual-update-lists: manual-check-dependencies-lists > $(Q)$(call MESSAGE,"Updating the manual lists...") > $(Q)BR2_DEFCONFIG="" TOPDIR=$(TOPDIR) O=$(O)/docs/manual/.build \ > + BR2_EXTERNAL=$(TOPDIR)/support/dummy-external \ I think I understand that change: we do not want to generate the manual with the external packages. Please extend the commit log. > $(TOPDIR)/support/scripts/gen-manual-lists.py > > # we can't use suitable-host-package here because that's not available in > diff --git a/support/scripts/kconfiglib.py b/support/scripts/kconfiglib.py > index 0704cc0..e40947c 100644 > --- a/support/scripts/kconfiglib.py > +++ b/support/scripts/kconfiglib.py > @@ -2074,7 +2074,7 @@ set_re = re.compile(r"CONFIG_(\w+)=(.*)") > unset_re = re.compile(r"# CONFIG_(\w+) is not set") > > # Regular expression for finding $-references to symbols in strings > -sym_ref_re = re.compile(r"\$[A-Za-z_]+") > +sym_ref_re = re.compile(r"\$[A-Za-z_][0-9A-Za-z_]*") I fail to see how this change is related to BR2_EXTERNAL. Care to explain (and extend the commit log at the same time), please? > # Integers representing symbol types > UNKNOWN, BOOL, TRISTATE, STRING, HEX, INT = range(0, 6) > -- > 1.8.1.2 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'