From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package: unification of name <pkg>_VERSION_MAJOR variable
Date: Mon, 2 Dec 2013 09:53:32 +0100 [thread overview]
Message-ID: <20131202095332.47b85913@skate> (raw)
In-Reply-To: <20131202095237.0241c919@skate>
Jerzy,
On Mon, 2 Dec 2013 09:52:37 +0100, Thomas Petazzoni wrote:
> Dear Jerzy Grzegorek,
>
> On Mon, 2 Dec 2013 09:00:02 +0100, Jerzy Grzegorek wrote:
>
> > -JSON_GLIB_VERSION = $(JSON_GLIB_MAJOR_VERSION).$(JSON_GLIB_MINOR_VERSION)
> > -JSON_GLIB_SITE = http://ftp.gnome.org/pub/GNOME/sources/json-glib/$(JSON_GLIB_MAJOR_VERSION)
> > +JSON_GLIB_VERSION = $(JSON_GLIB_VERSION_MAJOR).$(JSON_GLIB_MINOR_VERSION)
>
> So we have VERSION_MAJOR and then MINOR_VERSION ? Doesn't seem really
> consistent.
Ok, ignore that comment, sorry. I did review PATCH 1/2, and only after
that I saw PATCH 2/2. So just ignore my stupidity :)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-02 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 8:00 [Buildroot] [PATCH 1/2] package: unification of name <pkg>_VERSION_MAJOR variable Jerzy Grzegorek
2013-12-02 8:00 ` [Buildroot] [PATCH 2/2] package: unification of name <pkg>_VERSION_MINOR variable Jerzy Grzegorek
2013-12-02 8:52 ` [Buildroot] [PATCH 1/2] package: unification of name <pkg>_VERSION_MAJOR variable Thomas Petazzoni
2013-12-02 8:53 ` Thomas Petazzoni [this message]
2013-12-08 21:25 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202095332.47b85913@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox