From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bluez_utils: broken for static builds
Date: Tue, 3 Dec 2013 20:05:22 +0100 [thread overview]
Message-ID: <20131203200522.589c0e30@skate> (raw)
In-Reply-To: <1386093039-56954-1-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Tue, 3 Dec 2013 17:50:39 +0000, Vicente Olivert Riera wrote:
> The bluez_utils package requires shared library support
> unconditionally. We can't fix it to make it build on static because,
> for instance, "plugin.c" file uses dlfcn and it's a basic prereq for
> bluetoothd, so add "depend on !BR2_PREFER_STATIC_LIB" to it and
> recursively to all packages that selects BR2_PACKAGE_BLUEZ_UTILS.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/d81/d81970024649c1e89c01da491c63760afdad6cb6/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Looks good, but please read
http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options,
which tells you that when a package depends on dynamic library support,
a corresponding comment should be added to inform the user of why the
package is not available.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-12-03 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 17:50 [Buildroot] [PATCH] bluez_utils: broken for static builds Vicente Olivert Riera
2013-12-03 19:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203200522.589c0e30@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox