From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv5 4/5] docs/manual: add explanations about BR2_EXTERNAL
Date: Wed, 4 Dec 2013 23:22:06 +0100 [thread overview]
Message-ID: <20131204222206.GF3332@free.fr> (raw)
In-Reply-To: <1386183373-17611-5-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2013-12-04 19:56 +0100, Thomas Petazzoni spake thusly:
> This commit updates the manual to add details on how to use the
> BR2_EXTERNAL feature.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
On its own, this patch breaks the manual generation, which is fixed by
the collowing patch. Maybe you could either switch them, or squash them
together (I'd prefer the first option).
Otherwise, see comments below...
[--SNIP--]
> +Then, have a +BR2_EXTERNAL/external.mk' file that looks like:
Incorrect formatting.
> +-----
I would add a leading line (but could well lie without it) like:
$(BR2_EXTERNAL)/
+-- Config.in
+-- external.mk
[...]
> ++-- Config.in
> ++-- external.mk
> ++-- board/
> +| +-- <boardname>/
> +| +-- linux.config
> +| +-- overlay/
> +| +-- etc/
> +| +-- <some file>
> ++-- configs/
> +| +-- <boardname>_defconfig
> ++-- package/
> + +-- package1/
> + | +-- Config.in
> + | +-- package1.mk
> + +-- package2/
> + +-- Config.in
> + +-- package2.mk
> +------
With the formatting fixed, you can add my:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Not Tested-by, since the build breaks without the next patch, even
though the manual gets generated OK in this case.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-12-04 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 18:56 [Buildroot] [PATCHv5 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Thomas Petazzoni
2013-12-04 18:56 ` [Buildroot] [PATCHv5 1/5] core: introduce the BR2_EXTERNAL variable Thomas Petazzoni
2013-12-04 22:05 ` Yann E. MORIN
2013-12-04 18:56 ` [Buildroot] [PATCHv5 2/5] core: allow external Config.in/makefile code to be integrated Thomas Petazzoni
2013-12-04 22:07 ` Yann E. MORIN
2013-12-04 18:56 ` [Buildroot] [PATCHv5 3/5] core: allow external defconfigs to be used Thomas Petazzoni
2013-12-04 22:11 ` Yann E. MORIN
2013-12-04 18:56 ` [Buildroot] [PATCHv5 4/5] docs/manual: add explanations about BR2_EXTERNAL Thomas Petazzoni
2013-12-04 22:22 ` Yann E. MORIN [this message]
2013-12-04 18:56 ` [Buildroot] [PATCHv5 5/5] manual: fix manual generation with BR2_EXTERNAL support Thomas Petazzoni
2013-12-04 22:28 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204222206.GF3332@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox