From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libfreefare: Fix build on static
Date: Thu, 5 Dec 2013 19:51:10 +0100 [thread overview]
Message-ID: <20131205185110.GD3405@free.fr> (raw)
In-Reply-To: <1386267434-7144-1-git-send-email-Vincent.Riera@imgtec.com>
Vicente, All,
On 2013-12-05 18:17 +0000, Vicente Olivert Riera spake thusly:
> This patch makes this package building correctly on static.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/f09/f09d515f0e7b6d78010f1ce624336ceaef624989/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> .../libfreefare-001-fix-static-build.patch | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
> create mode 100644 package/libfreefare/libfreefare-001-fix-static-build.patch
>
> diff --git a/package/libfreefare/libfreefare-001-fix-static-build.patch b/package/libfreefare/libfreefare-001-fix-static-build.patch
> new file mode 100644
> index 0000000..31dfa30
> --- /dev/null
> +++ b/package/libfreefare/libfreefare-001-fix-static-build.patch
> @@ -0,0 +1,10 @@
> +--- libfreefare-0.3.4/examples/Makefile.am.orig 2013-12-05 17:08:16.058185440 +0000
> ++++ libfreefare-0.3.4/examples/Makefile.am 2013-12-05 17:14:02.270548090 +0000
> +@@ -2,6 +2,7 @@
> +
> + AM_CFLAGS = -I. -I$(top_srcdir)/libfreefare @LIBNFC_CFLAGS@
> + AM_LDFLAGS = @LIBNFC_LIBS@
> ++LIBS = -lcrypto -lz
Note that libfreefare itself does not use libz, but libcrypto does.
The reason why -lz is missing is because libfreefare uses AC_CHECK_LIB
to check for libcrypto, when it should use PKG_CHECK_MODULES (which
correctly has" Libs.private: -ldl -lz )
So, if a fix was to be bopushed upstream, it would be to fix libfreefare
to use PKG_CHECK_MODULES, not this.
> + bin_PROGRAMS = mifare-classic-format \
> + mifare-classic-write-ndef \
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2013-12-05 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 18:17 [Buildroot] [PATCH] libfreefare: Fix build on static Vicente Olivert Riera
2013-12-05 18:51 ` Yann E. MORIN [this message]
2013-12-05 20:03 ` Yann E. MORIN
2014-01-09 10:27 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205185110.GD3405@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox