Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] What is an Acked-by?
Date: Thu, 5 Dec 2013 21:13:33 +0100	[thread overview]
Message-ID: <20131205201333.GG3405@free.fr> (raw)
In-Reply-To: <20131205201203.GF3405@free.fr>

Arnout, All,

On 2013-12-05 21:12 +0100, Yann E. MORIN spake thusly:
> On 2013-12-05 19:12 +0100, Arnout Vandecappelle spake thusly:
> > On 05/12/13 00:19, Yann E. MORIN wrote:
> > >Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > >Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > 
> >  If you've reviewed it and tested it, you would commit it if you had commit
> > access, right? So this could actually be an Acked-by, right? Or is my
> > understanding of these tags incorrect?
> 
> I'm following the definitions of Documentation/SubmittingPatches in my
> Linux kernel tree.
> 
> For example, I refer to:
>     Acked-by: does not necessarily indicate acknowledgement of the entire
>     patch.
> 
>     Reviewed-by:, instead, indicates that the patch has been reviewed
>     and found acceptable according to the Reviewer's Statement
>     [--SNIP statement--]
> 
> So, by providing both Reviewed-by and Tested by, I am explicitly stating
> that I did a review of the patch, and I tested it. Which, from my
> understanding, Acked-by does.

... Acked-by does *not*.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-12-05 20:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 23:14 [Buildroot] [PATCHv6 0/5] Keeping customizations outside the Buildroot tree with BR2_EXTERNAL Thomas Petazzoni
2013-12-04 23:14 ` [Buildroot] [PATCHv6 1/5] manual: fix manual generation in preparation for BR2_EXTERNAL support Thomas Petazzoni
2013-12-04 23:19   ` Yann E. MORIN
2013-12-05 18:12     ` [Buildroot] What is an Acked-by? Arnout Vandecappelle
2013-12-05 20:12       ` Yann E. MORIN
2013-12-05 20:13         ` Yann E. MORIN [this message]
2013-12-06  8:03           ` Thomas De Schampheleire
2013-12-06  9:49             ` Arnout Vandecappelle
2013-12-05  9:32   ` [Buildroot] [PATCHv6 1/5] manual: fix manual generation in preparation for BR2_EXTERNAL support Ryan Barnett
2013-12-04 23:14 ` [Buildroot] [PATCHv6 2/5] core: introduce the BR2_EXTERNAL variable Thomas Petazzoni
2013-12-05 12:39   ` Ryan Barnett
2013-12-04 23:14 ` [Buildroot] [PATCHv6 3/5] core: allow external Config.in/makefile code to be integrated Thomas Petazzoni
2013-12-05 12:40   ` Ryan Barnett
2013-12-04 23:14 ` [Buildroot] [PATCHv6 4/5] core: allow external defconfigs to be used Thomas Petazzoni
2013-12-05 12:41   ` Ryan Barnett
2013-12-04 23:14 ` [Buildroot] [PATCHv6 5/5] docs/manual: add explanations about BR2_EXTERNAL Thomas Petazzoni
2013-12-05 12:00   ` Ryan Barnett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131205201333.GG3405@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox