From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ktap: new package
Date: Sun, 8 Dec 2013 14:19:25 +0100 [thread overview]
Message-ID: <20131208141925.67fa9aea@skate> (raw)
In-Reply-To: <1384172666-25736-1-git-send-email-anders@chargestorm.se>
Dear Anders Darander,
On Mon, 11 Nov 2013 13:24:26 +0100, Anders Darander wrote:
> +KTAP_VERSION = 0.3
> +KTAP_SITE = https://github.com/ktap/ktap/archive
> +KTAP_SOURCE = v$(KTAP_VERSION).tar.gz
> +KTAP_LICENSE = GPLv2
> +KTAP_LICENSE_FILES = LICENSE-GPL
> +
> +KTAP_DEPENDENCIES = linux
> +
> +define KTAP_BUILD_CMDS
> + $(MAKE) -C $(@D) CC=${TARGET_CC} ktap
Can you use:
$(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) ktap
instead ?
> + $(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNEL_SRC=$(LINUX_DIR) KVERSION=${LINUX_VERSION_PROBED} mod
KVERSION=$(LINUX_VERSION_PROBED)
i.e use $() instead of ${}, since LINUX_VERSION_PROBED is a make
variable.
> +endef
> +
> +define KTAP_INSTALL_TARGET_CMDS
> + $(INSTALL) -m755 $(@D)/ktap $(TARGET_DIR)/usr/bin/
$(INSTALL) -D -m755 $(@D)/ktap $(TARGET_DIR/usr/bin/ktap
> + $(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNEL_SRC=$(LINUX_DIR) KVERSION=${LINUX_VERSION_PROBED} modules_install
Ditto for the ${} -> $().
> +endef
> +
> +$(eval $(generic-package))
Other than that, looks good to me!
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-08 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 12:24 [Buildroot] [PATCH 1/1] ktap: new package Anders Darander
2013-12-08 11:44 ` Anders Darander
2013-12-08 13:19 ` Thomas Petazzoni [this message]
2013-12-08 13:24 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2013-12-08 13:47 Anders Darander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131208141925.67fa9aea@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox