From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] knock: Fix build failure due to missing README file.
Date: Thu, 12 Dec 2013 14:19:06 +0200 [thread overview]
Message-ID: <20131212121906.GL1217@tarshish> (raw)
In-Reply-To: <1386850072-18797-1-git-send-email-Vincent.Riera@imgtec.com>
Hi Vicente,
On Thu, Dec 12, 2013 at 12:07:52PM +0000, Vicente Olivert Riera wrote:
> Apply upstream patch: 306a696c0882f28a5cd2e41d392c3a6ed14d45f4
>
> The build process fails because Makefile.am includes README as part of
> the documentation files, but actually it doesn't exist:
>
> make[2]: *** No rule to make target `README', needed by `all-am'. Stop.
>
> The right file is README.md, so making that replacement to Makefile.am
> fixes the problem.
>
> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> .../knock/knock-001-Fix-missing-README-file.patch | 32 ++++++++++++++++++++
> 1 files changed, 32 insertions(+), 0 deletions(-)
> create mode 100644 package/knock/knock-001-Fix-missing-README-file.patch
>
> diff --git a/package/knock/knock-001-Fix-missing-README-file.patch b/package/knock/knock-001-Fix-missing-README-file.patch
> new file mode 100644
> index 0000000..ea0a779
> --- /dev/null
> +++ b/package/knock/knock-001-Fix-missing-README-file.patch
> @@ -0,0 +1,32 @@
> +From 306a696c0882f28a5cd2e41d392c3a6ed14d45f4 Mon Sep 17 00:00:00 2001
> +From: vriera <Vincent.Riera@imgtec.com>
> +Date: Tue, 10 Dec 2013 12:40:13 +0000
> +Subject: [PATCH] Update Makefile.am
> +
> +Fix build failure due to missing README file.
> +
> +The build process fails because Makefile.am includes README as part of the documentation files, but actually it doesn't exist:
> +
> +make[2]: *** No rule to make target `README', needed by `all-am'. Stop.
> +
> +The right file is README.md, so making that replacement to Makefile.am fixes the problem.
We need your sing-off on the added patch as well.
baruch
> +---
> + Makefile.am | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index b46e8c4..1a95e90 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -10,7 +10,7 @@ man_MANS += doc/knockd.1
> + sysconf_DATA = knockd.conf
> + endif
> +
> +-dist_doc_DATA = README TODO ChangeLog COPYING
> ++dist_doc_DATA = README.md TODO ChangeLog COPYING
> +
> + knock_SOURCES = src/knock.c
> + knockd_SOURCES = src/knockd.c src/list.c src/list.h
> +--
> +1.8.5.1
> +
> --
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2013-12-12 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 12:07 [Buildroot] [PATCH v2] knock: Fix build failure due to missing README file Vicente Olivert Riera
2013-12-12 12:19 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212121906.GL1217@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox