Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] bonnie: does not support static builds
Date: Tue, 17 Dec 2013 12:41:49 +0100	[thread overview]
Message-ID: <20131217124149.312b1d8e@skate> (raw)
In-Reply-To: <1387279718-6528-1-git-send-email-spdawson@gmail.com>

Simon,

On Tue, 17 Dec 2013 11:28:38 +0000, spdawson at gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
> 
> Fixes autobuild failues such as the following.
> 
>   http://autobuild.buildroot.net/results/bb9/bb9665a957e4fed25dff3e36bbf105c523dcf0a7/
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>  package/bonnie/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/bonnie/Config.in b/package/bonnie/Config.in
> index 6dbd06d..a4a50f8 100644
> --- a/package/bonnie/Config.in
> +++ b/package/bonnie/Config.in
> @@ -2,11 +2,12 @@ config BR2_PACKAGE_BONNIE
>  	bool "bonnie++"
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_USE_MMU # fork()
> +	depends on !BR2_PREFER_STATIC_LIB
>  	help
>  	  Filesystem tester
>  
>  	  http://www.coker.com.au/bonnie++/
>  
> -comment "bonnie++ needs a toolchain w/ C++"
> +comment "bonnie++ needs a toolchain w/ C++, dynamic library"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +	depends on !BR2_INSTALL_LIBSTDCPP	|| BR2_PREFER_STATIC_LIB

I need to test this specific case, but I don't think this is the
correct fix. If you look at the config.log file, I'm pretty sure you
will see that configure bails out because libstdc++.a does not exist.
This is a problem in the internal toolchain rework I've done, and that
I need to have a look at (make sure it generates the static version of
libstdc++).

Therefore, I don't think this patch should be applied: bonnie++, by
itself, does not require dynamic library.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-12-17 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 11:28 [Buildroot] [PATCH] bonnie: does not support static builds spdawson at gmail.com
2013-12-17 11:41 ` Thomas Petazzoni [this message]
2013-12-17 11:43   ` Simon Dawson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217124149.312b1d8e@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox