From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD
Date: Sat, 21 Dec 2013 09:39:03 +0100 [thread overview]
Message-ID: <20131221093903.22afccf9@skate> (raw)
In-Reply-To: <20131220224557.GB3484@free.fr>
Dear Yann E. MORIN,
On Fri, 20 Dec 2013 23:45:57 +0100, Yann E. MORIN wrote:
> > Do you know if there is a way of making kconfig complain loudly if
> > there is a reference to an undefined symbol?
>
> No, this is not even a warning.
>
> When Kconfig parsess a 'depends on' line, if the symbol does not exist
> yet, it is added to the list of symbols, in case it is defined later
> on.
Ok.
> But then there is no way to know if a symbol was added because there
> was a corresponding 'config' (or 'menuconfig' or 'choice') entry in
> any of the Config.in files, or because it was added due to it being
> listed in a 'depends on' (or a 'select').
Can't we add this information? When you find a symbol, if it's through
a depends on or a select, you store the symbol, but mark it as
"referenced". When you find a symbol that is really defined through
config/menuconfig/choice, you store the symbol and mark it as
"defined" (or changed from "referenced" to "defined" if the symbol had
already been found). And then, at the end of the parsing, if there are
some remaining symbols marked "referenced", whose state has not been
changed to "defined", you warn about them.
Am I dreaming too much about kconfig ? :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-21 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 21:02 [Buildroot] [PATCH] gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREAD Thomas De Schampheleire
2013-12-19 21:32 ` Peter Korsgaard
2013-12-20 8:50 ` Thomas Petazzoni
2013-12-20 22:45 ` Yann E. MORIN
2013-12-21 8:39 ` Thomas Petazzoni [this message]
2013-12-21 13:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131221093903.22afccf9@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox