From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] How to create the package from software using "bootstrap" to configure?
Date: Sat, 21 Dec 2013 19:01:42 +0100 [thread overview]
Message-ID: <20131221190142.2b544e69@skate> (raw)
In-Reply-To: <CAMduVEdFGug0_xhipRUJqnhMCELZ72Q6vcZLhWVAQzDdbBDuyA@mail.gmail.com>
Dear Wojciech Zabolotny,
On Sat, 21 Dec 2013 18:54:57 +0100, Wojciech Zabolotny wrote:
> Thanks. I have created Config.in and avrdude.mk as attached, and they
> seem to work (however I want to test it better before I submit the
> patch proposal).
Looks pretty good. A few comments:
* In the Config.in file, you need to inherit the dependencies of the
libraries you're selecting. For example, libusb depends on thread
support, so avrdude should depend on thread support. See
http://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options
for details.
* In your .mk file, use the github helper function instead of a
complete github URL.
* The license is GPLv2+, not GPLv2.
* You should add AVRDUDE_LICENSE_FILES = avrdude/COPYING
* You should remove the AVRDUDE_INSTALL_TARGET line, since YES is
the default value.
* You should add a comment on top of the AUTORECONF line explaining
why it is needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-12-21 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-21 13:15 [Buildroot] How to create the package from software using "bootstrap" to configure? Wojciech Zabolotny
2013-12-21 13:46 ` Thomas Petazzoni
2013-12-21 17:54 ` Wojciech Zabolotny
2013-12-21 18:01 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131221190142.2b544e69@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox