Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] external python modules: remove redundant python dependency
Date: Wed, 25 Dec 2013 09:56:20 +0100	[thread overview]
Message-ID: <20131225095620.7e4d611c@skate> (raw)
In-Reply-To: <7ffd4acd582283fb083a.1387905292@argentina>

Dear Thomas De Schampheleire,

On Tue, 24 Dec 2013 18:14:52 +0100, Thomas De Schampheleire wrote:
> File package/Config.in already groups the external python modules inside a
> 'if BR2_PACKAGE_PYTHON ... endif' statement, so adding a
> 'depends on BR2_PACKAGE_PYTHON' statement to the individual Config.in files
> is not needed.
> 
> This is in line with the way gstreamer packages are handled.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

I don't agree with this change. This duplication of "depends on" is
going to be really useful when we enable Python packages to be compiled
with Python 3. When we'll do this, we will change the:

if BR2_PACKAGE_PYTHON
source ...
source ...
endif

to:

if BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
source ...
source ...
endif

But still we will want to be able to decide on a per-package basis
which package is available for Python 2.x, for Python 3.x or for both.

Therefore, I'd like to keep these "depends on" for the moment.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-12-25  8:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-24 17:14 [Buildroot] [PATCH] external python modules: remove redundant python dependency Thomas De Schampheleire
2013-12-25  8:56 ` Thomas Petazzoni [this message]
2013-12-25  9:05   ` Thomas De Schampheleire
2013-12-25  9:18     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131225095620.7e4d611c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox