From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dbus-cpp: new package
Date: Thu, 26 Dec 2013 16:24:07 +0100 [thread overview]
Message-ID: <20131226162407.2debd602@skate> (raw)
In-Reply-To: <1388070026-4256-1-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Thu, 26 Dec 2013 12:00:26 -0300, Gustavo Zacarias wrote:
> D-Bus C++ bindings, closes bug #65.
Wow, impressive, you even go to improvement bugs, and fix them!
> diff --git a/package/dbus-cpp/Config.in b/package/dbus-cpp/Config.in
> new file mode 100644
> index 0000000..f631ece
> --- /dev/null
> +++ b/package/dbus-cpp/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_DBUS_CPP
> + bool "dbus-c++"
> + depends on BR2_PACKAGE_DBUS
> + depends on BR2_TOOLCHAIN_HAS_THREADS # dbus
> + depends on BR2_USE_MMU # dbus
> + depends on BR2_INSTALL_LIBSTDCPP
> + select BR2_PACKAGE_EXPAT
> + help
> + dbus-c++ attempts to provide a C++ API for D-BUS.
> + The library has a glib/gtk and an Ecore mainloop integration.
> + It also offers an optional own main loop.
> +
> + http://sourceforge.net/projects/dbus-cplusplus/
> +
> +comment "dbus-c++ needs a toolchain w/ C++, threads"
> + depends on BR2_USE_MMU
> + depends on BR2_PACKAGE_DBUS
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/dbus-cpp/dbus-cpp-0001-gcc4.7.patch b/package/dbus-cpp/dbus-cpp-0001-gcc4.7.patch
> new file mode 100644
> index 0000000..ad3046c
> --- /dev/null
> +++ b/package/dbus-cpp/dbus-cpp-0001-gcc4.7.patch
> @@ -0,0 +1,17 @@
> +Fix build failure with gcc 4.7+
> +From bugtracker: http://sourceforge.net/p/dbus-cplusplus/patches/13/
> +
> +Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> +
> +diff --git a/include/dbus-c++/eventloop-integration.h b/include/dbus-c++/eventloop-integration.h
> +index 1b0302e..3e44304 100644
> +--- a/include/dbus-c++/eventloop-integration.h
> ++++ b/include/dbus-c++/eventloop-integration.h
> +@@ -26,6 +26,7 @@
> + #define __DBUSXX_EVENTLOOP_INTEGRATION_H
> +
> + #include <errno.h>
> ++#include <unistd.h>
> + #include "api.h"
> + #include "dispatcher.h"
> + #include "util.h"
> diff --git a/package/dbus-cpp/dbus-cpp.mk b/package/dbus-cpp/dbus-cpp.mk
> new file mode 100644
> index 0000000..7936abd
> --- /dev/null
> +++ b/package/dbus-cpp/dbus-cpp.mk
> @@ -0,0 +1,36 @@
> +################################################################################
> +#
> +# dbus-c++
> +#
> +################################################################################
> +
> +DBUS_CPP_VERSION = 0.9.0
> +DBUS_CPP_SITE = http://downloads.sourceforge.net/project/dbus-cplusplus/dbus-c++/$(DBUS_CPP_VERSION)
> +DBUS_CPP_SOURCE = libdbus-c++-$(DBUS_CPP_VERSION).tar.gz
> +DBUS_CPP_INSTALL_STAGING = YES
> +# expat is required for the tools irrespective of dbus xml backend
> +DBUS_CPP_DEPENDENCIES = host-dbus-cpp host-pkgconf dbus expat
> +HOST_DBUS_CPP_DEPENDENCIES = host-pkgconf host-dbus host-expat
> +DBUS_CPP_CONF_OPT = --disable-examples --disable-tests --disable-doxygen-docs \
> + --with-build-libdbus-cxx=$(HOST_DBUS_CPP_BUILDDIR)
I'm not a big fan when building one package requires poking into the
source/build tree of another package (even if it's the host variant of
the same package). Installing the host dbus-cpp into $(HOST_DIR) isn't
sufficient to build the target dbus-cpp?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-12-26 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 15:00 [Buildroot] [PATCH] dbus-cpp: new package Gustavo Zacarias
2013-12-26 15:24 ` Thomas Petazzoni [this message]
2013-12-26 15:43 ` Gustavo Zacarias
2014-01-05 10:24 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226162407.2debd602@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox