Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] toolchain-external: update Linaro AArch64 toolchains
Date: Sun, 29 Dec 2013 18:32:00 +0100	[thread overview]
Message-ID: <20131229173200.GF3567@free.fr> (raw)
In-Reply-To: <1388143942-1187-5-git-send-email-thomas.petazzoni@free-electrons.com>

Thomas, All,

On 2013-12-27 12:32 +0100, Thomas Petazzoni spake thusly:
> Add Linaro AArch64 2013.10 and Linaro AArch64 2013.11, and remove
> Linaro AArch64 2013.07 and Linaro AArch64 2013.08.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

But see below, unrelated comment...

[--SNIP--]
> diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk
> index 0e12c76..6a44eaf 100644
> --- a/toolchain/toolchain-external/toolchain-external.mk
> +++ b/toolchain/toolchain-external/toolchain-external.mk
> @@ -339,15 +339,15 @@ TOOLCHAIN_EXTERNAL_SOURCE = lin32-microblaze-unknown-linux-gnu_14.3_early.tar.xz
>  else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_XILINX_MICROBLAZEBE_V2),y)
>  TOOLCHAIN_EXTERNAL_SITE = http://sources.buildroot.net/
>  TOOLCHAIN_EXTERNAL_SOURCE = microblaze-unknown-linux-gnu.tgz
> -else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_07),y)
> -TOOLCHAIN_EXTERNAL_SITE = http://releases.linaro.org/13.07/components/toolchain/binaries/
> -TOOLCHAIN_EXTERNAL_SOURCE = gcc-linaro-aarch64-linux-gnu-4.8-2013.07-1_linux.tar.xz
> -else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_08),y)
> -TOOLCHAIN_EXTERNAL_SITE = http://releases.linaro.org/13.08/components/toolchain/binaries/
> -TOOLCHAIN_EXTERNAL_SOURCE = gcc-linaro-aarch64-linux-gnu-4.8-2013.08_linux.tar.xz
>  else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_09),y)
>  TOOLCHAIN_EXTERNAL_SITE = http://releases.linaro.org/13.09/components/toolchain/binaries/
>  TOOLCHAIN_EXTERNAL_SOURCE = gcc-linaro-aarch64-linux-gnu-4.8-2013.09_linux.tar.xz
> +else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_10),y)
> +TOOLCHAIN_EXTERNAL_SITE = http://releases.linaro.org/13.10/components/toolchain/binaries/
> +TOOLCHAIN_EXTERNAL_SOURCE = gcc-linaro-aarch64-linux-gnu-4.8-2013.10-1_linux.tar.xz
> +else ifeq ($(BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64_13_11),y)
> +TOOLCHAIN_EXTERNAL_SITE = http://releases.linaro.org/13.11/components/toolchain/binaries/
> +TOOLCHAIN_EXTERNAL_SOURCE = gcc-linaro-aarch64-linux-gnu-4.8-2013.11_linux.tar.xz
>  else
>  # Custom toolchain
>  TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL)))

I find it odd that the menu are listed with reverse order, most recent
first, while the Makefiles are listed in order, oldest first. This
applies to all toolchains, not only the Linaro ones.

Of course, this is not the fault of this patch, as you kept the previous
order. So it does not bar you from applying it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-12-29 17:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 11:32 [Buildroot] [PATCH 0/6] Various external toolchain updates Thomas Petazzoni
2013-12-27 11:32 ` [Buildroot] [PATCH 1/6] toolchain-external: add Sourcery ARM 2013.11, remove Sourcery ARM 2011.09 Thomas Petazzoni
2013-12-29 17:19   ` Yann E. MORIN
2013-12-27 11:32 ` [Buildroot] [PATCH 2/6] toolchain-external: add Sourcery MIPS 2013.11, remove Sourcery MIPS 2012.03 Thomas Petazzoni
2013-12-27 11:56   ` Baruch Siach
2013-12-29 17:26   ` Yann E. MORIN
2013-12-27 11:32 ` [Buildroot] [PATCH 3/6] toolchain-external: update Linaro ARM toolchains Thomas Petazzoni
2013-12-27 11:32 ` [Buildroot] [PATCH 4/6] toolchain-external: update Linaro AArch64 toolchains Thomas Petazzoni
2013-12-29 17:32   ` Yann E. MORIN [this message]
2013-12-29 17:40   ` Thomas De Schampheleire
2013-12-29 17:53     ` Thomas Petazzoni
2013-12-29 21:51       ` Peter Korsgaard
2014-01-02 13:17         ` Thomas De Schampheleire
2014-01-02 13:29           ` Thomas Petazzoni
2014-01-02 14:13             ` Thomas De Schampheleire
2013-12-27 11:32 ` [Buildroot] [PATCH 5/6] toolchain-external: mark Microblaze external toolchains as deprecated Thomas Petazzoni
2013-12-29 17:38   ` Yann E. MORIN
2013-12-27 11:32 ` [Buildroot] [PATCH 6/6] toolchain-external: add support for the Blackfin 2013R1 toolchain Thomas Petazzoni
2013-12-29 17:40   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131229173200.GF3567@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox