From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions
Date: Thu, 2 Jan 2014 14:33:16 +0200 [thread overview]
Message-ID: <20140102123316.GD6589@tarshish> (raw)
In-Reply-To: <20140102132318.7315ddde@skate>
Hi Thomas,
On Thu, Jan 02, 2014 at 01:23:18PM +0100, Thomas Petazzoni wrote:
> On Thu, 2 Jan 2014 13:53:03 +0200, Baruch Siach wrote:
> > Fixes
> > http://autobuild.buildroot.net/results/70b/70b79ca0aa97ed451a5679029955ed3709c84b67/.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/uclibc/uClibc-snapshot.config | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config
> > index 9ca3f9ea983d..890aefd8ec59 100644
> > --- a/package/uclibc/uClibc-snapshot.config
> > +++ b/package/uclibc/uClibc-snapshot.config
> > @@ -152,7 +152,7 @@ UCLIBC_LINUX_SPECIFIC=y
> > UCLIBC_HAS_GNU_ERROR=y
> > UCLIBC_BSD_SPECIFIC=y
> > UCLIBC_HAS_BSD_ERR=y
> > -# UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is not set
> > +UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y
>
> We don't have this option enabled in the uClibc-0.9.33.config. Is there
> a reason why it should be enabled for the uClibc-snapshot.config and
> not for uClibc-0.9.33.config ? Does netsnmp builds with uClibc 0.9.33
> on some other architecture?
The netsnmp configure scripts tests for sighold(). This test fails when
UCLIBC_HAS_OBSOLETE_BSD_SIGNAL is disabled. In this case the code in
apps/snmpnetstat/if.c uses the alternative sigblock() API. This has been
removed completely from uClibc after 0.9.33 with commit 5aa7aa7fa7ec2a
(signal: remove sigblock, siggetmask and sigsetmask). That's why we need
UCLIBC_HAS_OBSOLETE_BSD_SIGNAL for netsnmp to build only when uClibc snapshot
is selected.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-01-02 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 11:53 [Buildroot] [PATCH] uclibc: snapshot: add BSD obsolete signal functions Baruch Siach
2014-01-02 12:23 ` Thomas Petazzoni
2014-01-02 12:33 ` Baruch Siach [this message]
2014-01-10 23:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140102123316.GD6589@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox