Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain/external: fix wrapper by not passing conflicting flags
Date: Mon, 6 Jan 2014 18:07:56 +0100	[thread overview]
Message-ID: <20140106170756.GA3383@free.fr> (raw)
In-Reply-To: <CAGduivx4AZW3ic8HvVDtCwe7tdb4v-w7PEwVOPb_D6gSz82mtA@mail.gmail.com>

On 2014-01-06 17:07 +0100, Maxime Hadjinlian spake thusly:
> On Mon, Jan 6, 2014 at 1:12 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > In our wrapper, we forcibly add the -march=, -mcpu= and-mtune= flags
> > to the actual copmpiler, this in an attempt to always generate correct
> > and optimised code for the target.
[--SNIP--]
> > @@ -157,6 +153,31 @@ int main(int argc, char **argv)
> >                 *cur++ = "-mfloat-abi=" BR_FLOAT_ABI;
> >  #endif
> >
> > +#if defined(BR2_ARCH) || \
> > +    defined(BR2_TUNE) || \
> > +    defined(BR2_CPU)
> Shouldn't this be BR_* ?

Doh, yes indeed. Good catch. :-)

> After modifying to use BR instead of BR2 variable, your patch did what
> was intended.
> It suppressed all theses pesky messages while building the kernel.
> 
> I am currently doing a full build, will report once it's done.

Thank you! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-01-06 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06  0:12 [Buildroot] [PATCH] toolchain/external: fix wrapper by not passing conflicting flags Yann E. MORIN
2014-01-06 16:07 ` Maxime Hadjinlian
2014-01-06 17:07   ` Yann E. MORIN [this message]
2014-01-06 17:36     ` Maxime Hadjinlian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106170756.GA3383@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox