Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Zick <minimod@morethan.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v10 8/8] Makefile: update comment about top-level parallel Makefile
Date: Tue, 7 Jan 2014 07:17:52 -0600	[thread overview]
Message-ID: <20140107071752.65e91042@core2quad.morethan.org> (raw)
In-Reply-To: <CAHkwnC-7A=vf1fQ6HNxqRtxpfLuKz3fDWh68Ea_EEpVakzXH9w@mail.gmail.com>

On Tue, 7 Jan 2014 11:05:52 +0100
Fabio Porcedda <fabio.porcedda@gmail.com> wrote:

> This is the fixed comment:
> 
> # Parallel execution of this Makefile is disabled because it changes
> # the packages building order, that can be a problem when a package
> # has an unspecified optional dependency, because if that dependency
> # is present when the package is built, it is used, otherwise it isn't
> # (but compilation happily proceeds). This means that the packages
> # building order is relevant in that case, and the end result will
> # differ if the order is swapped due to parallel building.  Also
> # changing the building order can be a problem if two packages
> # manipulate the same file in the target directory.
> # Taking into account the above warnings, if you still want to execute
> # this top-level Makefile in parallel comment the following line and
> # execute:
> #    make BR2_JLEVEL= -j$((`getconf _NPROCESSORS_ONLN`+1))
> 
> Regards
>

Been a silent reader for years here now, but I just must make a
suggestion:

# Parallel execution of this top-level Makefile is disabled.
#
# Single execution is forced here for two reasons:
#
# Maintaining reproducible builds:
# Packages with an unspecified, optional, dependency could
# otherwise change the build order among multiple builds.
#
# Prevent file modification collisions:
# This can happen if two packages manipulate the same file.
#
# After taking into account the above considerations;
# If you still want to execute this top-level Makefile in 
# parallel, comment out the following line and then execute:
#    make BR2_JLEVEL= -j$((`getconf _NPROCESSORS_ONLN`+1))

Just clarify which line is "the following line" in the context
of this comment. 

Add styling to first line of each paragraph to match the context.

- - - -

I will return now to my read-only mode.
Mike

  reply	other threads:[~2014-01-07 13:17 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 10:36 [Buildroot] [PATCH v10 0/8] Add support for top-level parallel make Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 1/8] package: add base dependency to every package Fabio Porcedda
2014-01-09 17:30   ` Arnout Vandecappelle
2014-01-10 10:28     ` Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 2/8] package: add toolchain dependency to every target package Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 3/8] package: add support for top-level parallel make Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 4/8] uclibc: " Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 5/8] glibc: " Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 6/8] Makefile: " Fabio Porcedda
2013-12-18 10:36 ` [Buildroot] [PATCH v10 7/8] package: enable jobserver for recursive make Fabio Porcedda
2013-12-19 17:27   ` Arnout Vandecappelle
2013-12-20 13:24     ` Fabio Porcedda
2013-12-20 15:47       ` Arnout Vandecappelle
2013-12-19 20:32   ` Peter Korsgaard
2013-12-20 13:05     ` Fabio Porcedda
2013-12-20 14:54       ` Peter Korsgaard
2013-12-18 10:36 ` [Buildroot] [PATCH v10 8/8] Makefile: update comment about top-level parallel Makefile Fabio Porcedda
2013-12-19 17:37   ` Arnout Vandecappelle
2013-12-20 13:56     ` Fabio Porcedda
2013-12-20 15:48       ` Arnout Vandecappelle
2014-01-07 10:05         ` Fabio Porcedda
2014-01-07 13:17           ` Mike Zick [this message]
2014-01-09  8:10             ` Fabio Porcedda
2013-12-19 17:33 ` [Buildroot] [PATCH v10 0/8] Add support for top-level parallel make Arnout Vandecappelle
2013-12-20 14:36   ` Fabio Porcedda
2013-12-20 15:34     ` Thomas Petazzoni
2013-12-20 15:46       ` Arnout Vandecappelle
2013-12-20 16:01         ` Fabio Porcedda
2014-01-08  9:56   ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107071752.65e91042@core2quad.morethan.org \
    --to=minimod@morethan.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox