Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] python-posix-ipc: new package
Date: Tue, 7 Jan 2014 14:17:23 +0800	[thread overview]
Message-ID: <20140107141723.0d5b6f4c@skate> (raw)
In-Reply-To: <1389043097-30018-1-git-send-email-mlweber1@rockwellcollins.com>

Dear Matt Weber,

On Mon, 6 Jan 2014 15:18:17 -0600, Matt Weber wrote:

> diff --git a/package/python-posix-ipc/Config.in b/package/python-posix-ipc/Config.in
> new file mode 100644
> index 0000000..2fbc7a7
> --- /dev/null
> +++ b/package/python-posix-ipc/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_POSIX_IPC
> +	bool "python-posix-ipc"
> +	depends on BR2_PACKAGE_PYTHON

I see #include <pthread.h> in the C code of the module, so maybe this
Python module should depend on BR2_TOOLCHAIN_HAS_THREADS?

> +PYTHON_POSIX_IPC_VERSION = 0.9.6
> +PYTHON_POSIX_IPC_SOURCE = posix_ipc-$(PYTHON_POSIX_IPC_VERSION).tar.gz
> +PYTHON_POSIX_IPC_SITE = http://semanchuk.com/philip/posix_ipc/
> +PYTHON_POSIX_IPC_LICENSE = BSD-2c

License is BSD-3c, not BSD-2c.

> +PYTHON_POSIX_IPC_LICENSE_FILES = LICENSE
> +PYTHON_POSIX_IPC_SETUP_TYPE = distutils

Other than that, looks good to me (but I haven't tested).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-01-07  6:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 21:18 [Buildroot] [PATCH 1/1] python-posix-ipc: new package Matt Weber
2014-01-07  6:17 ` Thomas Petazzoni [this message]
2014-01-07 14:15   ` Matthew Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140107141723.0d5b6f4c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox