From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler
Date: Wed, 8 Jan 2014 23:45:25 +0800 [thread overview]
Message-ID: <20140108234525.49fae894@skate> (raw)
In-Reply-To: <1389188913-15173-1-git-send-email-jeremy.rosen@openwide.fr>
Dear J?r?my Rosen,
On Wed, 8 Jan 2014 14:48:33 +0100, J?r?my Rosen wrote:
> + $(if $(BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV),
> + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
These two last lines are not needed, we already have:
$(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
$(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
Note the two commas at the end of the first line. It means that when
BR2_ROOTFS_DEVICE_CREATION_STATIC is *NOT* enabled, then we enabled
devtmpfs and devtmpfs_mount.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-08 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 13:48 [Buildroot] [PATCH] force devtmpfs and inotify kernel option when udev is used as dev handler Jérémy Rosen
2014-01-08 14:13 ` Danomi Manchego
2014-01-08 15:42 ` Jeremy Rosen
2014-01-08 15:45 ` Thomas Petazzoni [this message]
2014-01-09 8:03 ` Jeremy Rosen
2014-01-08 21:28 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140108234525.49fae894@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox