Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/14] libenca: new package
Date: Mon, 13 Jan 2014 16:20:28 +0800	[thread overview]
Message-ID: <20140113162028.688f4e7f@skate> (raw)
In-Reply-To: <1389549208-19078-3-git-send-email-maxime.hadjinlian@gmail.com>

Dear Maxime Hadjinlian,

On Sun, 12 Jan 2014 18:53:16 +0100, Maxime Hadjinlian wrote:
> Extremely Naive Charset Analyser.
> 
> This package was originally found at : https://github.com/huceke/buildroot-rbp
> By gimli <ebsi4711@gmail.com>
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/Config.in                                  |  1 +
>  package/libenca/Config.in                          |  6 ++++
>  package/libenca/libenca-1.9-dont-build-tools.patch | 33 ++++++++++++++++++++++
>  package/libenca/libenca-1.9-fix-clean.patch        | 22 +++++++++++++++
>  package/libenca/libenca-1.9-fix-prefix.patch       | 19 +++++++++++++

We don't want the version number of package in the patch file names,
but we do want sequence numbers. So:

	libenca-000-<something>.patch
	libenca-001-<something>.patch

> diff --git a/package/libenca/libenca-1.9-dont-build-tools.patch b/package/libenca/libenca-1.9-dont-build-tools.patch
> new file mode 100644
> index 0000000..43b3420
> --- /dev/null
> +++ b/package/libenca/libenca-1.9-dont-build-tools.patch
> @@ -0,0 +1,33 @@
> +diff -ruN libenca-1.9.orig/Makefile.in libenca-1.9/Makefile.in
> +--- libenca-1.9.orig/Makefile.in	2011-07-23 20:02:58.304328321 -0400
> ++++ libenca-1.9/Makefile.in	2011-07-23 20:03:34.246328297 -0400
> +@@ -78,7 +78,7 @@


> diff --git a/package/libenca/libenca-1.9-fix-clean.patch b/package/libenca/libenca-1.9-fix-clean.patch
> new file mode 100644
> index 0000000..9c206ad
> --- /dev/null
> +++ b/package/libenca/libenca-1.9-fix-clean.patch
> @@ -0,0 +1,22 @@
> +--- libenca-1.9.orig/src/Makefile.in	2011-07-23 20:19:28.744327998 -0400
> ++++ libenca-1.9/src/Makefile.in	2011-07-23 20:22:47.894327936 -0400

> diff --git a/package/libenca/libenca-1.9-fix-prefix.patch b/package/libenca/libenca-1.9-fix-prefix.patch
> new file mode 100644
> index 0000000..6fd195b
> --- /dev/null
> +++ b/package/libenca/libenca-1.9-fix-prefix.patch
> @@ -0,0 +1,19 @@
> +--- libenca-1.9.orig/configure
> ++++ libenca-1.9/configure

We generally prefer to patch the Makefile.am and the configure.{in,ac}
script, and set <foo>_AUTORECONF = YES.

> +#############################################################
> +#
> +# libenca
> +#
> +#############################################################

80 # signs are needed now.

> +
> +LIBENCA_VERSION = 1.9
> +LIBENCA_SITE = http://dl.cihar.com/enca
> +LIBENCA_SOURCE = enca-$(LIBENCA_VERSION).tar.bz2
> +LIBENCA_INSTALL_STAGING = YES
> +LIBENCA_LICENSE = GPLv2
> +LIBENCA_LICENSE_FILES = COPYING
> +
> +LIBENCA_CONF_ENV += ac_cv_file__dev_random=yes
> +LIBENCA_CONF_ENV += ac_cv_file__dev_urandom=yes
> +LIBENCA_CONF_ENV += ac_cv_file__dev_arandom=no
> +LIBENCA_CONF_ENV += ac_cv_file__dev_srandom=no
> +LIBENCA_CONF_ENV += yeti_cv_func_scanf_modif_size_t=yes

Use (i.e on one line) :

LIBENCA_CONF_ENV = \
	bleh=yes \
	foo=bar \
	bar=bleh

> +define LIBENCA_MAKE_HOST_TOOL
> +cd $(@D)/tools && $(HOSTCC) -o make_hash make_hash.c

Instead with one tab.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-01-13  8:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 17:53 [Buildroot] [PATCH 00/14] Introducing XBMC Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 01/14] jasper: new package Maxime Hadjinlian
2014-01-12 18:29   ` Peter Korsgaard
2014-01-12 17:53 ` [Buildroot] [PATCH 02/14] libenca: " Maxime Hadjinlian
2014-01-13  8:20   ` Thomas Petazzoni [this message]
2014-01-14 22:14   ` Yann E. MORIN
2014-01-12 17:53 ` [Buildroot] [PATCH 03/14] libass: " Maxime Hadjinlian
2014-01-12 18:37   ` Bernd Kuhls
2014-01-14 22:17   ` Yann E. MORIN
2014-01-14 22:23     ` Yann E. MORIN
2014-01-12 17:53 ` [Buildroot] [PATCH 04/14] libbluray: " Maxime Hadjinlian
2014-01-12 18:40   ` Bernd Kuhls
2014-01-14 22:26   ` Yann E. MORIN
2014-01-12 17:53 ` [Buildroot] [PATCH 05/14] libcdio: " Maxime Hadjinlian
2014-01-12 18:40   ` Bernd Kuhls
2014-01-14 22:32   ` Yann E. MORIN
2014-01-12 17:53 ` [Buildroot] [PATCH 06/14] libmodplug: " Maxime Hadjinlian
2014-01-12 18:41   ` Bernd Kuhls
2014-01-14 22:36   ` Yann E. MORIN
2014-01-15 20:55   ` Peter Korsgaard
2014-01-15 23:19     ` Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 07/14] libnfs: " Maxime Hadjinlian
2014-01-12 18:42   ` Bernd Kuhls
2014-01-14 22:38   ` Yann E. MORIN
2014-01-12 17:53 ` [Buildroot] [PATCH 08/14] libplist: " Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 09/14] librtmp: " Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 10/14] libshairplay: " Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 11/14] tinyxml: " Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 12/14] sdl: add host version Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 13/14] sdl_image: " Maxime Hadjinlian
2014-01-12 17:53 ` [Buildroot] [PATCH 14/14] xbmc: new package Maxime Hadjinlian
2014-01-12 18:15   ` Maxime Hadjinlian
2014-01-28 21:44     ` Thomas Petazzoni
2014-01-12 18:33 ` [Buildroot] [PATCH 00/14] Introducing XBMC Bernd Kuhls
2014-01-12 18:39   ` Maxime Hadjinlian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140113162028.688f4e7f@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox