Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] arch: add support for "jaguar" AMD CPU optimisations.
Date: Mon, 13 Jan 2014 19:05:20 +0100	[thread overview]
Message-ID: <20140113180520.GD3344@free.fr> (raw)
In-Reply-To: <1755668586.279162.1389632820523.JavaMail.root@mail>

Adiren, All,

On 2014-01-13 12:07 -0500, Adrien B?raud spake thusly:
> This new version forces the use of GCC 4.8:

When sending an updated version of a patch:
  - add a 'v2' (or v3, v4...) to the subject, such that it is obvious a
    previous patch was sent:
        [PATCH v2] arch: add support for "jaguar" AMD CPU
    You can do that with: git send-email --annotate

  - keep the initial commit log, and ammend it accordingly, for example:

    AMD Jaguar ( https://en.wikipedia.org/wiki/Jaguar_%28microarchitecture%29 ) is
    suddenly a popular architecture since it is used in the PS4 and the XBox One.
    Many embedded systems are also likely to use it in the next years.

    This patch adds support for GCC architecture-specific optimizations and
    tuning for these CPUs, and locks it to only gcc-4.8 (since it is the
    earliest version with support for jaguar).

I don't have much more to say about the patch itself.

However...

> Signed-off-by: Adrien Beraud <adrien.beraud@savoirfairelinux.com>
[--SNIP--]
> diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
> index 41c1213..db14564 100644
> --- a/package/gcc/Config.in.host
> +++ b/package/gcc/Config.in.host
> @@ -18,12 +18,12 @@ choice
>  		bool "gcc 4.2.2-avr32-2.1.5"
>  
>  	config BR2_GCC_VERSION_4_3_X
> -		depends on !BR2_arc && !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_cortex_a5 && !BR2_cortex_a7 && !BR2_cortex_a8 && !BR2_cortex_a9 && !BR2_cortex_a15 && !BR2_x86_atom && !BR2_powerpc_e300c2 && !BR2_powerpc_e300c3 && !BR2_powerpc_e500mc && !BR2_powerpc_464 && !BR2_powerpc_464fp && !BR2_powerpc_476 && !BR2_powerpc_476fp && !BR2_fa526 && !BR2_pj4
> +		depends on !BR2_arc && !BR2_avr32 && !BR2_sparc_sparchfleon && !BR2_sparc_sparchfleonv8 && !BR2_sparc_sparcsfleon && !BR2_sparc_sparcsfleonv8 && !BR2_cortex_a5 && !BR2_cortex_a7 && !BR2_cortex_a8 && !BR2_cortex_a9 && !BR2_cortex_a15 && !BR2_x86_atom && !BR2_x86_jaguar && !BR2_powerpc_e300c2 && !BR2_powerpc_e300c3 && !BR2_powerpc_e500mc && !BR2_powerpc_464 && !BR2_powerpc_464fp && !BR2_powerpc_476 && !BR2_powerpc_476fp && !BR2_fa526 && !BR2_pj4

... I do not like those very long lines. But that has nothing to do with
your patch per-se...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-01-13 18:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1368377135.187677.1389630463088.JavaMail.root@mail>
2014-01-13 16:37 ` [Buildroot] [PATCH] arch: add support for "jaguar" AMD CPU optimisations Adrien Béraud
2014-01-13 17:07   ` Adrien Béraud
2014-01-13 18:05     ` Yann E. MORIN [this message]
2014-01-13 18:11     ` [Buildroot] [PATCH v2] " Adrien Béraud
2014-01-13 20:09       ` [Buildroot] [PATCH v3] " Adrien Béraud
2014-01-14 17:06         ` Arnout Vandecappelle
2014-01-15 16:20         ` [Buildroot] [PATCH v4] " Adrien Béraud
2014-01-15 20:40           ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140113180520.GD3344@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox