From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/6] [RFC] some download-related changes
Date: Wed, 15 Jan 2014 00:39:52 +0100 [thread overview]
Message-ID: <20140114233952.GM3328@free.fr> (raw)
In-Reply-To: <52D5AE9F.6070105@mind.be>
Arnout, All,
On 2014-01-14 22:39 +0100, Arnout Vandecappelle spake thusly:
> On 13/01/14 00:44, Yann E. MORIN wrote:
> >The first part, patch 1 to 3, are a fix the git download helper, which
> >is currently broken in case a PKG_VERSION is a sha1 that does not exist
> >in the repository.
> >
> >Since the make macro was a bit complex to read and maintain, Peter
> >suggested it be moved to a shell script. If this change is OK, I'll
> >move the other download helpers to their own shell script.
>
> I would actually move all of $(DOWNLOAD) into a single helper script. I
> expect that that will give you a lot of refactoring opportunities.
I also wondered if I'd do that.
But for a first iteration of the series, I decided to just dip a toe in
the water to check if it was not too hot! ;-)
And then, I think I prefer multiple scripts, one for each VCS. It's not
like doing a 'gzip -c' is too complex, after all, since that's the only
thing they'll gona share.
But let's see what others think of it.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-01-14 23:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 23:44 [Buildroot] [PATCH 0/6] [RFC] some download-related changes Yann E. MORIN
2014-01-12 23:44 ` [Buildroot] [PATCH 1/6] Makefile: rename USER_HOOKS_EXTRA_ENV to EXTRA_ENV Yann E. MORIN
2014-01-14 20:44 ` Arnout Vandecappelle
2014-01-12 23:44 ` [Buildroot] [PATCH 2/6] pkg-infra: move git download helper to a script Yann E. MORIN
2014-01-13 14:18 ` Luca Ceresoli
2014-01-13 17:51 ` Yann E. MORIN
2014-01-14 20:39 ` Arnout Vandecappelle
2014-01-14 22:49 ` Yann E. MORIN
2014-01-12 23:44 ` [Buildroot] [PATCH 3/6] pkg-infra: git helper creates an empty archive if PKG_VERSION is a missing hash Yann E. MORIN
2014-01-13 14:22 ` Luca Ceresoli
2014-01-13 17:50 ` Yann E. MORIN
2014-01-14 20:43 ` Arnout Vandecappelle
2014-01-14 23:21 ` Yann E. MORIN
2014-01-15 8:17 ` Arnout Vandecappelle
2014-01-17 22:35 ` Yann E. MORIN
2014-01-12 23:44 ` [Buildroot] [PATCH 4/6] package infra: DOWNLOAD is never called with two arguments Yann E. MORIN
2014-01-14 20:51 ` Arnout Vandecappelle
2014-01-12 23:44 ` [Buildroot] [PATCH 5/6] pkg-infra: add possiblity to check downloaded files against known hashes Yann E. MORIN
2014-01-13 4:53 ` Baruch Siach
2014-01-13 17:52 ` Yann E. MORIN
2014-01-14 21:37 ` Arnout Vandecappelle
2014-01-14 23:34 ` Yann E. MORIN
2014-01-15 8:22 ` Arnout Vandecappelle
2014-01-15 13:22 ` Gustavo Zacarias
2014-01-17 23:02 ` Yann E. MORIN
2014-01-18 0:33 ` Gustavo Zacarias
2014-01-17 22:41 ` Yann E. MORIN
2014-01-18 15:53 ` Luca Ceresoli
2014-01-15 0:08 ` Gustavo Zacarias
2014-01-12 23:44 ` [Buildroot] [PATCH 6/6] package/ca-certificates: add tarball's hash Yann E. MORIN
2014-01-14 21:39 ` [Buildroot] [PATCH 0/6] [RFC] some download-related changes Arnout Vandecappelle
2014-01-14 23:39 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114233952.GM3328@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox