From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/3] Rename MySQL client package
Date: Tue, 21 Jan 2014 23:06:38 +0100 [thread overview]
Message-ID: <20140121220638.GC3455@free.fr> (raw)
In-Reply-To: <1390313310-3453-1-git-send-email-kuyurix@gmail.com>
Marcelo, All,
On 2014-01-21 14:08 +0000, Marcelo Guti?rrez spake thusly:
> MySQL client package has been renamed to MySQL.
>
> Signed-off-by: Marcelo Guti?rrez <kuyurix@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, a minor nit, see below...
> diff --git a/package/mysql_client/Config.in b/package/mysql/Config.in
> similarity index 61%
> rename from package/mysql_client/Config.in
> rename to package/mysql/Config.in
> index 543bed1..229e050 100644
> --- a/package/mysql_client/Config.in
> +++ b/package/mysql/Config.in
> @@ -1,13 +1,14 @@
> -config BR2_PACKAGE_MYSQL_CLIENT
> - bool "MySQL client"
> +config BR2_PACKAGE_MYSQL
> + bool "MySQL"
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_USE_MMU # fork()
> depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_NCURSES
> select BR2_PACKAGE_READLINE
> help
> - MySQL client
> + The MySQL Open Source Database System
This hould be a leading tab and two spaces. No need to resend, Peter can
fix while committing, I guess! ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-01-21 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 14:08 [Buildroot] [PATCH v2, 1/3] Rename MySQL client package Marcelo Gutiérrez
2014-01-21 22:06 ` Yann E. MORIN [this message]
2014-01-21 22:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121220638.GC3455@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox