Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] Makefile: use absolute paths to BR2_EXTERNAL
Date: Sun, 26 Jan 2014 14:53:42 +0100	[thread overview]
Message-ID: <20140126145342.4c5ccc4e@skate> (raw)
In-Reply-To: <44e6c31931f55e79eec713be1a202f2c170667b7.1390424303.git.yann.morin.1998@free.fr>

Dear Yann E. MORIN,

On Wed, 22 Jan 2014 21:59:34 +0100, Yann E. MORIN wrote:

> +is interpreted relative to the main Buildroot source directory, not
> +the Buildroot output directory. Using relative paths can lead to various
> +broken setups, and thus is highly discouraged in favour of using
> +absolute paths.

In this patch and in patch 3/3, I don't quite agree with the strong
suggestion to use absolute paths. I personally find the usage of
absolute paths ugly, and prefer to have in the manual an explanation on
how the paths are interpreted, so that the users can understand how to
properly use either relative paths or absolute paths as they prefer.

To me, a tool that strongly suggests to use absolute paths is broken.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-01-26 13:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 20:59 [Buildroot] [PATCH 0/3] BR2_EXTERNAL, O: misc fixes and docs Yann E. MORIN
2014-01-22 20:59 ` [Buildroot] [PATCH 1/3] Makefile: use absolute paths to BR2_EXTERNAL Yann E. MORIN
2014-01-22 21:22   ` Samuel Martin
2014-01-23  8:48   ` Jeremy Rosen
2014-01-26 13:53   ` Thomas Petazzoni [this message]
2014-01-27 17:18     ` Arnout Vandecappelle
2014-02-02 10:19       ` Yann E. MORIN
2014-02-02 10:16     ` Yann E. MORIN
2014-01-27 17:26   ` Arnout Vandecappelle
2014-02-02 10:23     ` Yann E. MORIN
2014-02-02 11:01       ` Arnout Vandecappelle
2014-02-02 11:09         ` Yann E. MORIN
2014-01-22 20:59 ` [Buildroot] [PATCH 2/3] manual: $(BR2_EXTERNAL)/{Config.in, external.mk} are mandatory Yann E. MORIN
2014-01-22 21:18   ` Samuel Martin
2014-01-22 20:59 ` [Buildroot] [PATCH 3/3] manual: add explanations on limitation about using O= Yann E. MORIN
2014-01-22 21:18   ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140126145342.4c5ccc4e@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox