From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Run post scripts referenced by relative paths
Date: Tue, 28 Jan 2014 19:32:02 +0100 [thread overview]
Message-ID: <20140128183202.GC3466@free.fr> (raw)
In-Reply-To: <CAHKzcEM_-gWUPe_cSYQCoUtgywMwmi8Wkjyy25UqgMGSRQto8A@mail.gmail.com>
Waldemar, All,
On 2014-01-28 11:50 +0100, Waldemar Rymarkiewicz spake thusly:
> > I am not sure I fully get your patch, what is wrong with putting
> > path/to/my_script.sh ? You don't have to specify the full path, a
> > relative path works well.
>
> Nothing is wrong to put full path to your scripts. Just a matter of
> what you prefer.
>
> Try to put script file in buildroot directory and set the post script
> variable using just the name of the script. I does not work for me
> and I'm pretty sure it does not work for you as well. This is simply
> how Makefile calls the scripts.
>
> This patch is just addition to run post scripts referenced by relative
> paths as well, nothing more.
Why don't you just set:
BR2_ROOTFS_POST_BUILD_SCRIPT="./my-script ./my-second-script"
(Ditto for BR2_ROOTFS_POST_IMAGE_SCRIPT.)
I'd say, we don't need that change. I prefer the user be explixit about
what he intends to do, rather than Buildroot guessing.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-01-28 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 10:14 [Buildroot] [PATCH] Run post scripts referenced by relative paths Waldemar Rymarkiewicz
2014-01-28 10:37 ` Maxime Hadjinlian
2014-01-28 10:50 ` Waldemar Rymarkiewicz
2014-01-28 11:08 ` Maxime Hadjinlian
2014-01-28 18:32 ` Yann E. MORIN [this message]
2014-01-28 21:41 ` Thomas Petazzoni
2014-01-28 22:06 ` Waldemar Rymarkiewicz
2014-01-28 22:15 ` Thomas Petazzoni
2014-01-28 22:17 ` Yann E. MORIN
2014-01-28 17:00 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128183202.GC3466@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox