From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] cwiid: new package
Date: Tue, 28 Jan 2014 19:38:53 +0100 [thread overview]
Message-ID: <20140128193853.5ab63cf1@skate> (raw)
In-Reply-To: <1388689257-31068-1-git-send-email-s.martin49@gmail.com>
Dear Samuel Martin,
On Thu, 2 Jan 2014 20:00:57 +0100, Samuel Martin wrote:
> +if BR2_PACKAGE_CWIID
> +config BR2_PACKAGE_CWIID_WMGUI
> + bool "wmgui"
> + depends on BR2_PACKAGE_XORG7 # libgtk2
> + depends on BR2_USE_WCHAR # libgtk2 -> libglib2
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2
> + depends on BR2_USE_MMU # libgtk2 -> libglib2
> + depends on BR2_INSTALL_LIBSTDCPP # libgtk2 -> pango
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_PACKAGE_LIBGTK2
> +endif
> +ifeq ($(BR2_PACKAGE_CWIID_WMGUI),y)
> +CWIID_DEPENDENCIES += libgtk2 libglib2
> +CWIID_CONF_OPT += --enable-wmgui
> +else
> +CWIID_CONF_OPT += --disable-wmgui
> +endif
That's a very minor nitpick, but libgtk2 strongly requires libglib2, so
selecting and depending on both isn't very useful. Having the select
and dependency on gtk2 would probably have been sufficient, IMO.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-01-28 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 19:00 [Buildroot] [PATCH v2] cwiid: new package Samuel Martin
2014-01-13 22:14 ` Peter Korsgaard
2014-01-28 18:38 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140128193853.5ab63cf1@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox