From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 28 Jan 2014 22:41:33 +0100 Subject: [Buildroot] [PATCH] Run post scripts referenced by relative paths In-Reply-To: <20140128183202.GC3466@free.fr> References: <1390904090-27934-1-git-send-email-waldemar.rymarkiewicz@gmail.com> <20140128183202.GC3466@free.fr> Message-ID: <20140128224133.3a145dd0@skate> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Yann E. MORIN, On Tue, 28 Jan 2014 19:32:02 +0100, Yann E. MORIN wrote: > On 2014-01-28 11:50 +0100, Waldemar Rymarkiewicz spake thusly: > > > I am not sure I fully get your patch, what is wrong with putting > > > path/to/my_script.sh ? You don't have to specify the full path, a > > > relative path works well. > > > > Nothing is wrong to put full path to your scripts. Just a matter of > > what you prefer. > > > > Try to put script file in buildroot directory and set the post script > > variable using just the name of the script. I does not work for me > > and I'm pretty sure it does not work for you as well. This is simply > > how Makefile calls the scripts. > > > > This patch is just addition to run post scripts referenced by relative > > paths as well, nothing more. > > Why don't you just set: > BR2_ROOTFS_POST_BUILD_SCRIPT="./my-script ./my-second-script" > > (Ditto for BR2_ROOTFS_POST_IMAGE_SCRIPT.) > > I'd say, we don't need that change. I prefer the user be explixit about > what he intends to do, rather than Buildroot guessing. I agree. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com